chore(lint): enable clippy::panic_in_result_fn#96
Open
tupe12334 wants to merge 1 commit into
Open
Conversation
Deny panic!/todo!/unimplemented!/unreachable! inside functions that return Result or Option. When a function's return type already models failure, an internal panic bypasses structured error propagation and crashes the process instead of returning Err(_)/None for callers to handle. The codebase has zero violations today; this commit locks in that clean state and prevents future regressions. Closes #95
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enable the
clippy::panic_in_result_fnrestriction lint, which flagspanic!,todo!,unimplemented!, andunreachable!calls inside functions that returnResultorOption.Why
When a function's return type already models fallibility, an internal panic bypasses structured error propagation — the process crashes instead of returning
Err(_)/Nonefor the caller to handle. This lint enforces the invariant thatResult/Option-returning functions stay within the type system's error-handling contract.What changed
Added to
[lints.clippy]inCargo.toml:The codebase has zero violations today — this commit locks in that clean state and prevents future regressions.
Verification
cargo clippy --all-targetspasses with no warnings or errors. Pre-push hook (clippy + build + 100% coverage) also passed.Closes #95
This pull request was opened by the Clippy lint improvements → issue + PR (Rust repos) → Slack routine of moadim. CC @tupe12334