Skip to content

fix(passwordless): encode session IDs in send URLs #441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gjtorikian wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(passwordless): encode session IDs in send URLs #441

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/Passwordless.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ public function sendSession(string $sessionId): void
{
$this->client->request(
method: 'POST',
path: "passwordless/sessions/{$sessionId}/send",
path: 'passwordless/sessions/' . rawurlencode($sessionId) . '/send',
body: [],
);
}
Expand Down
28 changes: 28 additions & 0 deletions tests/PasswordlessTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,34 @@ public function testSendSession(): void
);
}

public function testSendSessionEncodesSessionIdAsSinglePathSegment(): void
{
$cases = [
'session/other' => 'session%2Fother',
'../other' => '..%2Fother',
'session/../../other' => 'session%2F..%2F..%2Fother',
'session?query=value#fragment' => 'session%3Fquery%3Dvalue%23fragment',
'session%2Fother' => 'session%252Fother',
'session with spaces' => 'session%20with%20spaces',
'session+other' => 'session%2Bother',
];

foreach ($cases as $sessionId => $encodedSessionId) {
$client = $this->createMockClient([['status' => 204]]);
$client->passwordless()->sendSession($sessionId);
$request = $this->getLastRequest();
$this->assertSame('POST', $request->getMethod());
$this->assertSame(
'/passwordless/sessions/' . $encodedSessionId . '/send',
$request->getUri()->getPath(),
$sessionId,
);
$this->assertSame('', $request->getUri()->getQuery());
$this->assertSame('', $request->getUri()->getFragment());
$this->assertSame('{}', (string) $request->getBody());
}
}

public function testPasswordlessAccessibleFromClient(): void
{
$client = $this->createMockClient([]);
Expand Down
Loading