Skip to content

Add MediaUploader actor with broadcast queue lifecycle - #25621

Open
crazytonyli wants to merge 2 commits into
trunkfrom
task/media-v2-upload-engine
Open

Add MediaUploader actor with broadcast queue lifecycle#25621
crazytonyli wants to merge 2 commits into
trunkfrom
task/media-v2-upload-engine

Conversation

@crazytonyli

@crazytonyli crazytonyli commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Note

This PR will be merged after #25620.

This PR adds a MediaUploader type, which is a site wide singleton, for managing the end-to-end uploading states. The next PR in the stack uses it on UI.

@dangermattic

dangermattic commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator
2 Warnings
⚠️ Modules/Package.swift was changed without updating its corresponding Package.resolved.

If the change includes adding, removing, or editing a dependency please resolve the Swift packages as appropriate to your project setup (e.g. in Xcode or by running swift package resolve).

If the change to the Package.swift did not modify dependencies, ignoring this warning should be safe, but we recommend double checking and running the package resolution just in case.
.

⚠️ This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
1 Message
📖 This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

@wpmobilebot

wpmobilebot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

🤖 Build Failure Analysis

This build has failures. Claude has analyzed them - check the build annotations for details.

@crazytonyli
crazytonyli force-pushed the task/media-v2-upload-engine branch from 0e6ecbf to d4572b8 Compare June 8, 2026 23:18
@wpmobilebot

wpmobilebot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor
App Icon📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress
ConfigurationRelease-Alpha
Build Number34023
VersionPR #25621
Bundle IDorg.wordpress.alpha
Commit5e4e90f
Installation URL4aj8ueiuij9g8
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@wpmobilebot

wpmobilebot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor
App Icon📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack
ConfigurationRelease-Alpha
Build Number34023
VersionPR #25621
Bundle IDcom.jetpack.alpha
Commit5e4e90f
Installation URL7ba7mep8vkh40
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@crazytonyli
crazytonyli force-pushed the task/media-v2-upload-engine branch from d4572b8 to 8f96db5 Compare June 11, 2026 00:32
@crazytonyli
crazytonyli force-pushed the task/media-v2-upload-engine branch from 8f96db5 to adab6df Compare June 11, 2026 21:30
@crazytonyli
crazytonyli force-pushed the task/media-v2-upload-engine branch from adab6df to d4a7b1b Compare June 12, 2026 00:50
@crazytonyli
crazytonyli force-pushed the task/media-v2-upload-engine branch 2 times, most recently from e91673a to db8160b Compare June 16, 2026 08:28
@crazytonyli
crazytonyli force-pushed the task/media-v2-upload-engine branch 2 times, most recently from fb748dd to 675d2da Compare June 19, 2026 00:20
@crazytonyli
crazytonyli force-pushed the task/media-v2-upload-engine branch from 675d2da to 6bb0246 Compare July 7, 2026 22:09
Base automatically changed from task/media-v2-upload-materializer to trunk August 26, 2026 00:00
@crazytonyli
crazytonyli force-pushed the task/media-v2-upload-engine branch 2 times, most recently from b64c362 to 33982f1 Compare August 26, 2026 07:39
Add a per-site upload queue actor that materializes each source, uploads
it, and publishes ordered pending/failed snapshots through a replaying
publisher. Supports cancel, retry, remove, bulk operations, live policy
refresh, and teardown, and cleans up staging directories on every exit
path. Materialization goes through a MediaSourceMaterializing seam so
tests can drive timing and outcomes with a mock.
@crazytonyli
crazytonyli force-pushed the task/media-v2-upload-engine branch from 33982f1 to 5e4e90f Compare August 26, 2026 23:49
@crazytonyli
crazytonyli requested a review from jkmassel August 26, 2026 23:57
@crazytonyli crazytonyli added this to the 27.3 milestone Aug 26, 2026
@crazytonyli
crazytonyli marked this pull request as ready for review August 26, 2026 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants