Extract the GBK editor parts to a super class - #25166

Merged

crazytonyli merged 31 commits into

trunkfrom

extract-gbk-editor-superclass

Feb 2, 2026

Commits on Jan 25, 2026

Create a new `PostGBKEditorViewController` super class
crazytonyli
committed
73bb0fb
Remove an unused initialiser
crazytonyli
committed
a6fc3d7
Remove unused parameters
crazytonyli
committed
ff5ecba
Move initialiser to the super class
crazytonyli
committed
94efa5c
Add empty `EditorViewControllerDelegate` implementation
crazytonyli
committed
65199d0
Add empty `PostEditorNavigationBarManagerDelegate` implementation
crazytonyli
committed
54aca0f
Add override keywords
crazytonyli
committed
c4a3f8d
Move `PostEditorNavigationBarManagerDelegate` implementation
crazytonyli
committed
9b8f6f0
Add override keywords
crazytonyli
committed
715a8a4
Remove private keyword
crazytonyli
committed
f6b7b3e
Remove empty override functions
crazytonyli
committed
c6b6826
Move `didUpdateHistoryState` delegate function to the super class
crazytonyli
committed
1e6144b
Move `didLogException` delegate function to the super class
crazytonyli
committed
a165d71
Move modal dialog delegate functions to the super class
crazytonyli
committed
20a16e3
Move undo redo delegate functions to the super class
crazytonyli
committed
3d0b473
Move keyboard observers to the super class
crazytonyli
committed
f0cf75c
Call setupKeyboardObservers in the super class
crazytonyli
committed
890ab3c
Move showSuggestions function to the super class
crazytonyli
committed
9147c85
Move `didTriggerAutocompleter` to the super class
crazytonyli
committed
b35e258
Move setting background
crazytonyli
committed
b66faed
Move deinit to the super class
crazytonyli
committed
ab3a0e1
Move `setupEditorView()` to the super class
crazytonyli
committed
7d05cc4
Move configureNavigationBar to the super class
crazytonyli
committed
32e4acb
Allow overriding `makeMoreMenu`
crazytonyli
committed
d0c92a7
Move `loadAuthenticationCookiesAsync` to the super class
crazytonyli
committed
acaada5
Move `prefetchSuggestionsIfNeeded` to the super class
crazytonyli
committed
22f0796
Move `refreshInterface` to the super class
crazytonyli
committed
1a2c8c4
Move the super class to its own file
crazytonyli
committed
8cead76
Move extension functions out to its own file
crazytonyli
committed
7e2cea6
Add missing imports
crazytonyli
committed
a140993
Add an extension: `EditorLocalizableString.localized`
crazytonyli
committed
f452c12

Navigation Menu

Extract the GBK editor parts to a super class - #25166

Extract the GBK editor parts to a super class#25166
crazytonyli merged 31 commits into
trunkfrom
extract-gbk-editor-superclass

Commits on Jan 25, 2026

Create a new `PostGBKEditorViewController` super class

Remove an unused initialiser

Remove unused parameters

Move initialiser to the super class

Add empty `EditorViewControllerDelegate` implementation

Add empty `PostEditorNavigationBarManagerDelegate` implementation

Add override keywords

Move `PostEditorNavigationBarManagerDelegate` implementation

Add override keywords

Remove private keyword

Remove empty override functions

Move `didUpdateHistoryState` delegate function to the super class

Move `didLogException` delegate function to the super class

Move modal dialog delegate functions to the super class

Move undo redo delegate functions to the super class

Move keyboard observers to the super class

Call setupKeyboardObservers in the super class

Move showSuggestions function to the super class

Move `didTriggerAutocompleter` to the super class

Move setting background

Move deinit to the super class

Move `setupEditorView()` to the super class

Move configureNavigationBar to the super class

Allow overriding `makeMoreMenu`

Move `loadAuthenticationCookiesAsync` to the super class

Move `prefetchSuggestionsIfNeeded` to the super class

Move `refreshInterface` to the super class

Move the super class to its own file

Move extension functions out to its own file

Add missing imports

Add an extension: `EditorLocalizableString.localized`