Remove duplicate sanitizeForLog helper from WolfSSLDebug - #414
Open
cconlon wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
It resolves a confirmed duplicate-definition compile error by removing one copy while leaving the intended sanitizer implementation intact.
Pull request overview
Removes a duplicate LOG_UNSAFE_CHARS / sanitizeForLog() definition in WolfSSLDebug.java that caused javac to fail with “already defined”, restoring master buildability while keeping the more complete sanitizer variant (including backslash for JSON safety).
Changes:
- Deletes the earlier duplicate
LOG_UNSAFE_CHARSPatternandsanitizeForLog()helper block. - Retains the later sanitizer implementation that also sanitizes backslash (
\) in addition to control chars and".
File summaries
| File | Description |
|---|---|
| src/java/com/wolfssl/WolfSSLDebug.java | Removes the duplicate log-sanitization helper to fix compilation; keeps the JSON-safer implementation. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
… harden socket stress tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the master build.
WolfSSLDebug.javadefinesLOG_UNSAFE_CHARSandsanitizeForLog()twice, added separately by PR #404 and PR #406 at different points in the file, so the merge did not conflict butjavacfails with "already defined".