Check some ignored return values in SFTP#964
Open
ejohnstown wants to merge 2 commits intowolfSSL:masterfrom
Open
Check some ignored return values in SFTP#964ejohnstown wants to merge 2 commits intowolfSSL:masterfrom
ejohnstown wants to merge 2 commits intowolfSSL:masterfrom
Conversation
Set ret = WS_BAD_FILE_E and jump to cleanup on parse failure instead of ignoring the return value. Issue: CID 645982
padelsbach
previously approved these changes
May 6, 2026
Capture the return value, clear state unconditionally, and report parse failure or non-OK server status via ssh->error instead of discarding the result. Issue: CID 572873
ejohnstown
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check return values from ParseAttributes in RecvOpen and from DoStatus in DoName.
Issue: CID 645982, CID 572873