Skip to content

Harden COSE parsing, key handling, and cryptographic operations #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattia-moffa merged 1 commit into from
Aug 21, 2026
Merged

Harden COSE parsing, key handling, and cryptographic operations #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/lean-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,8 @@ jobs:
gcc $SF -DWOLFCOSE_LEAN -c src/wolfcose.c -o /tmp/leanall.o
echo "== WOLFCOSE_LEAN_VERIFY =="
gcc $SF -DWOLFCOSE_LEAN_VERIFY -c src/wolfcose.c -o /tmp/lean.o
echo "== COSE_Mac without COSE_Mac0 =="
gcc $SF -DWOLFCOSE_NO_MAC0 -c src/wolfcose.c -o /tmp/mac-no-mac0.o
echo "== sign-only =="
gcc $SF -DWOLFCOSE_NO_SIGN1_VERIFY -DWOLFCOSE_NO_ENCRYPT0 -DWOLFCOSE_NO_MAC0 \
-DWOLFCOSE_NO_SIGN -DWOLFCOSE_NO_ENCRYPT -DWOLFCOSE_NO_MAC \
Expand Down
39 changes: 35 additions & 4 deletions .github/workflows/minimal-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,18 +22,29 @@ jobs:
- name: ECC-only
wolfssl_flags: "--enable-cryptonly --enable-ecc --enable-aesgcm --enable-keygen --enable-sha384 --enable-sha512 --enable-lowresource --enable-sp-math-all --disable-dh --disable-rsa --disable-aescbc --disable-sha --disable-md5 --disable-chacha --disable-poly1305 --disable-errorstrings"
cache_key: wolfssl-ecc-only-v5
- name: Deterministic ECDSA
wolfssl_flags: "--enable-cryptonly --enable-ecc --enable-aesgcm --enable-keygen --enable-sha384 --enable-sha512 --enable-lowresource --enable-sp-math-all --disable-dh --disable-rsa --disable-aescbc --disable-sha --disable-md5 --disable-chacha --disable-poly1305 --disable-errorstrings"
wolfssl_cppflags: "-DWOLFSSL_ECDSA_DETERMINISTIC_K -DWOLFSSL_NO_MALLOC"
cache_key: wolfssl-ecc-deterministic-v2
cose_flags: "-DWOLFCOSE_ENABLE_DETERMINISTIC_ECDSA"
- name: ECC fastmath ALT with bigint
wolfssl_flags: "--enable-cryptonly --enable-ecc --enable-aesgcm --enable-keygen --enable-sha384 --enable-sha512 --enable-fastmath --enable-lowresource --enable-asynccrypt --disable-dh --disable-rsa --disable-sha --disable-md5 --disable-chacha --disable-poly1305 --disable-errorstrings --disable-shared --enable-static"
cache_key: wolfssl-ecc-fast-alt-bigint-v1
compile_only: true
- name: EdDSA-only
wolfssl_flags: "--enable-cryptonly --enable-ed25519 --enable-curve25519 --enable-sha512 --enable-lowresource --disable-dh --disable-rsa --disable-errorstrings"
cache_key: wolfssl-eddsa-only-v6
wolfssl_flags: "--enable-cryptonly --disable-ecc --enable-ed25519 --enable-curve25519 --enable-sha512 --enable-lowresource --disable-dh --disable-rsa --disable-errorstrings"
cache_key: wolfssl-eddsa-only-v7
skip_tool_test: true
- name: Ed448-only
wolfssl_flags: "--enable-cryptonly --enable-ed448 --enable-sha512 --enable-lowresource --disable-dh --disable-rsa --disable-errorstrings"
cache_key: wolfssl-ed448-only-v3
- name: AEAD-only (no signing)
wolfssl_flags: "--enable-cryptonly --enable-aesgcm --enable-aesccm --enable-chacha --enable-poly1305 --enable-lowresource --disable-dh --disable-rsa --disable-errorstrings"
cache_key: wolfssl-aead-only-v6
- name: RSA-PSS-only
wolfssl_flags: "--enable-cryptonly --enable-rsapss --enable-keygen --enable-sha384 --enable-sha512 --enable-lowresource --disable-dh --disable-errorstrings"
cache_key: wolfssl-rsa-only-v6
wolfssl_flags: "--enable-cryptonly --enable-rsapss --enable-keygen --enable-sha384 --enable-sha512 --enable-lowresource --disable-ecc --disable-dh --disable-errorstrings"
cache_key: wolfssl-rsa-only-v7
skip_tool_test: true
- name: PQ (ML-DSA) only
wolfssl_flags: "--enable-cryptonly --enable-mldsa --disable-dh --disable-rsa --disable-errorstrings"
cache_key: wolfssl-pq-only-v4
Expand Down Expand Up @@ -77,27 +88,47 @@ jobs:
git clone --depth 1 https://github.com/wolfSSL/wolfssl.git wolfssl-minimal-src
cd wolfssl-minimal-src
./autogen.sh
export CPPFLAGS="${{ matrix.wolfssl_cppflags }}"
./configure ${{ matrix.wolfssl_flags }} \
--prefix=$HOME/wolfssl-minimal
make -j$(nproc)
make install

- name: Build wolfCOSE
if: matrix.compile_only != true
run: |
export WOLFSSL_DIR=$HOME/wolfssl-minimal
make CFLAGS="-std=c99 -DHAVE_ANONYMOUS_INLINE_AGGREGATES=1 -Os -Wall -Wextra -Wpedantic -Wshadow -Wconversion ${{ matrix.cose_flags }} -I./include -isystem $WOLFSSL_DIR/include" \
LDFLAGS="-L$WOLFSSL_DIR/lib -lwolfssl"

- name: Run unit tests
if: matrix.compile_only != true
run: |
export WOLFSSL_DIR=$HOME/wolfssl-minimal
export LD_LIBRARY_PATH=$WOLFSSL_DIR/lib
make test CFLAGS="-std=c99 -DHAVE_ANONYMOUS_INLINE_AGGREGATES=1 -Os -Wall -Wextra -Wpedantic -Wshadow -Wconversion ${{ matrix.cose_flags }} -I./include -isystem $WOLFSSL_DIR/include" \
LDFLAGS="-L$WOLFSSL_DIR/lib -lwolfssl"

- name: Run tool round-trip test
if: matrix.compile_only != true && matrix.skip_tool_test != true
run: |
export WOLFSSL_DIR=$HOME/wolfssl-minimal
export LD_LIBRARY_PATH=$WOLFSSL_DIR/lib
make tool-test CFLAGS="-std=c99 -DHAVE_ANONYMOUS_INLINE_AGGREGATES=1 -Os -Wall -Wextra -Wpedantic -Wshadow -Wconversion ${{ matrix.cose_flags }} -I./include -isystem $WOLFSSL_DIR/include" \
LDFLAGS="-L$WOLFSSL_DIR/lib -lwolfssl"

- name: Compile wolfCOSE policy profile
if: matrix.compile_only == true
run: |
export WOLFSSL_DIR=$HOME/wolfssl-minimal
for macro in ALT_ECC_SIZE USE_FAST_MATH HAVE_WOLF_BIGINT; do
if ! grep -Eq "^#define[[:space:]]+$macro([[:space:]]|$)" \
"$WOLFSSL_DIR/include/wolfssl/options.h"; then
echo "::error::Expected $macro in wolfSSL options.h"
exit 1
fi
done
cc -std=c99 -pedantic-errors -Werror -Wall -Wextra -Wshadow \
-Wconversion -Wvla -DHAVE_ANONYMOUS_INLINE_AGGREGATES=1 \
-I./include -isystem $WOLFSSL_DIR/include -fsyntax-only \
src/wolfcose.c tests/test_cose.c
Loading
Loading