Also check .lessignore for absolute file names, resolved with realpath#207
Open
g-v-egidy wants to merge 1 commit into
Open
Also check .lessignore for absolute file names, resolved with realpath#207g-v-egidy wants to merge 1 commit into
g-v-egidy wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this patch the entries in .lessignore were compared against a file parameter given to less on the commandline, globbing applied.
But what was not done is checking the absolute path of the resulting file. So consider you had
/var/log/messagesin your.lessignorefile, your current working directory is/var/logand you now callless messages. Before this patch, the file would be passed through colorization and so on, losing the ability to use the follow (F) mode.With this patch the relative filename as given on the commandline is compared as before. Additionally the absolute path is resolved and also compared, with globbing applied too.