add chunked mixed encoding support and deprecate direct decode with pest parser - #2
loulecrivain wants to merge 8 commits into
Conversation
|
cc @yuyuyureka would appreciate your opinion / review on the skeleton implementation, as it is my first time building stream adapters. also on the general okayness of the implem. given we need it to be retry-able by the client in case of error in stream. |
yuyuyureka
left a comment
There was a problem hiding this comment.
The general approach of the regex delimiter codec is good. There's not much code to review inside this PR (only ~50L). Does this compile with various feature flag combination like without async-streaming feature / --no-default-features? Does the re-delimiter-codec need to be an optional dependency only for the async-streaming feature?
Inside the re-delimiter-codec itself, there could be more docstrings to explain the usage and what regex to actually put into REDelimiterCodec::new() with an example of what splitting it would achieve (Should the regex match only the delimiter? or the full message? will the matched part be contained within the stream message?).
good catch Ill make sure to check
hmmm yes do agree could use a bit more documentation |
|
1st point resolved |
|
2nd point resolved |
cdf0c7d to
f552c2a
Compare
|
all review comments addressed, I'm gonna continue with the actual implementation. thanks! :) will drop tokio_stream when the new implentation works |
08bf69b to
f918fee
Compare
f918fee to
2c26837
Compare
No description provided.