Fix Game Blocking Issue (REI 26.1.x / owo-lib)

[KoalaMauve]

Find out there was an game blocking issue when both REI 26.1.x and owo-lib are loaded in the same instance :

Its caused by the rei_client entrypoint, which rededirecton the OwoReiPlugin.
The said class does no longer implement REIClientPlugin, which lead to this blocking error.
"entrypoints": { "rei_client": [ "io.wispforest.owo.compat.rei.OwoReiPlugin" ],

I've solved it by implementing back the REIClientPlugin (without uncommenting all the commented out code), fixing the issue on my side.

Note: I havent incremented the mod version, I do not know your system, so I let y'all deal with it.

[KoalaMauve]

Related to issure #487

[balutaeugen]

Were this changes tested? From what I can gather, REI for 26.1 changed a bit, rei_client now registers client/server plugins, while rei_client_v0 registers client-only plugins

Is OwoReiPlugin a client-only plugin? Then it needs to go to _v0 (which I think it should since REIClientPlugin is reserved for client-only plugins)
@gliscowo can you help here?

[KoalaMauve]

As mentioned, this fixed the issue on my side, although I haven’t done a full test with every mod depending on owo-lib.

My test setup was the following: REI 26.1 + Skyblocker (client-side recipes implementing REIClientPlugin), along with another mod depending on owo-lib, which seemed like a realistic test case.

It fixed the game loading issue, and both the default singleplayer recipes and Skyblocker’s custom recipes were still working. The mod relying on owo-lib was also working properly.

Since the whole OwoReiPlugin was commented out, I didn’t try to adapt it to the latest REI changes.

[Noaaan]

I don't think this is the "correct" way of fixing this issue. It just makes the plugin run without any operation.
I believe the commented out code is used for adding exclusion zones around the owo-lib item group buttons, so that they remain clickable even if REI appears over them.
This PR should address the issue by either completing that implementation, which you can verify by running the test mod and looking at any of the test groups, or by disabling it in the FMJ, removing this line:

owo-lib/src/main/resources/fabric.mod.json

Lines 27 to 29 in 344ba1a

	"rei_client": [
	"io.wispforest.owo.compat.rei.OwoReiPlugin"
	],

)

[KoalaMauve]

After debugging for 3h to re-enable REI Recipes exclusion zones, I gave up.
I have removed the OwoREIPlugin entry point in the FMJ, and did the same for the UwuREIPlugin (in order to share the same configuration for both mod & testmod).

I have not deleted the class file, as it may be used as a base for future devs...

All REI imports have been removed from the build.gradle.

With the said modifications, the game now starts w/o any issue.

Hope it is what you were excpeting @Noaaan

[KoalaMauve]

@Noaaan bumping this, I've seen than my "workaround" release have reached 200+ downloads, this official fix seem asked.

If you could try to approve & merge this, it would be appreciated (i did the exact fix you required btw).

[Noaaan]

I am not an owo-lib maintainer, and can therefore not do this at all

[dkoob]

This appears to still be a problem (at least on 21.1.2 with whatever mod configs and stuff I have), any word?