feat: Add minimal docker package skeleton INT-1031#3
Conversation
There was a problem hiding this comment.
Pull request overview
Adds an initial wb-docker Debian package skeleton intended to integrate Docker-related configuration on Wiren Board controllers, focusing on packaging structure and maintainer-script entrypoints rather than Docker Engine installation/configuration.
Changes:
- Added Debian packaging metadata (
debian/control,debian/changelog,debian/rules, install/dirs lists, source format). - Added maintainer scripts that call a reconcile helper, plus a minimal no-op reconcile implementation.
- Added default configuration templates and
wb-configsmanifest, along with basic repo docs/build helpers.
Reviewed changes
Copilot reviewed 17 out of 18 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| share/daemon.json | Adds a default Docker daemon config template (data/exec roots). |
| README.md | Documents repository purpose, layout, and build/check commands. |
| Makefile | Adds make check (shell syntax) and make build (dpkg-buildpackage) targets. |
| LICENSE | Adds the MIT-WB license text. |
| libexec/wb-docker-reconcile | Adds a minimal reconcile helper that prints invocation parameters. |
| debian/wb-docker.prerm | Adds prerm maintainer script invoking the reconcile helper. |
| debian/wb-docker.preinst | Adds preinst maintainer script invoking the reconcile helper when present. |
| debian/wb-docker.postrm | Adds postrm maintainer script invoking the reconcile helper when present. |
| debian/wb-docker.postinst | Adds postinst maintainer script invoking the reconcile helper. |
| debian/wb-docker.install | Declares files to install into the package. |
| debian/wb-docker.dirs | Declares directories to be created by the package. |
| debian/source/format | Sets the source package format to 3.0 (native). |
| debian/rules | Adds minimal debhelper rules with overrides for systemd helpers. |
| debian/copyright | Adds machine-readable copyright header and file/license mapping. |
| debian/control | Defines source/binary package metadata and dependencies (incl. wb-configs). |
| debian/changelog | Adds initial changelog entry for version 0.1.0. |
| configs/20wb-docker | Adds wb-configs manifest entry for /etc/docker. |
| .gitignore | Ignores common Debian build outputs and local editor/build artifacts. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| case "${1:-}" in | ||
| configure|abort-upgrade|abort-remove|abort-deconfigure) | ||
| "$helper" postinst "$1" "${2:-}" |
|
|
||
| case "${1:-}" in | ||
| remove|upgrade|deconfigure|failed-upgrade) | ||
| "$helper" prerm "$1" "${2:-}" |
vitalii-wb
left a comment
vitalii-wb
left a comment
There was a problem hiding this comment.
Посмотрел в первом приближении - оставил комментарии
Но надо видимо синхронизировать общие решения с видением перепаковки пакета которое недавно узнали
There was a problem hiding this comment.
Зачем нужен этот файл?
Кажется мы его нигде не используем в проектах
|
|
||
| * Initial package skeleton. | ||
|
|
||
| -- Denis Smagin <denis.smagin@wirenboard.com> Mon, 18 May 2026 12:00:00 +0200 No newline at end of file |
There was a problem hiding this comment.
в конце файла новой строки не хватает
| @@ -0,0 +1,17 @@ | |||
| Source: wb-docker | |||
| Section: admin | |||
There was a problem hiding this comment.
тут точно в секции нужно админ?
везде вроде другое ставим, например тут в облаке
https://github.com/wirenboard/wb-cloud-agent/blob/main/debian/control
There was a problem hiding this comment.
этот файл коллеги просят делать пустым
| @@ -0,0 +1,33 @@ | |||
| # wb-docker | |||
There was a problem hiding this comment.
ридми по дефолту пишем по русски к проектам - если не сказано иного
тут лучше по русски написать
There was a problem hiding this comment.
Файл лицензии не уверен что тут нужен
Что происходит; кому и зачем нужно:
INT-1031
Минимальный deb пакет
Что поменялось для пользователей:
Как проверял/а:
Собрал пакет