fix: Recover unestablished MLS groups - WPB-21123#5040
Open
acv-w wants to merge 5 commits into
Open
Conversation
acv-w
requested review from
a team,
David-Henner and
netbe
and removed request for
a team
July 21, 2026 16:28
Contributor
Test Results1 247 tests 1 247 ✅ 49s ⏱️ Results for commit 678161a. ♻️ This comment has been updated with latest results. Summary: workflow run #29901708326 |
caldrian
requested review from
a team,
KaterinaWire and
jullianm
and removed request for
a team,
David-Henner and
netbe
July 22, 2026 07:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
An MLS conversation can remain in Core Crypto at epoch 0. Because
conversationExistsstill returnstrue, the client incorrectly treats it as established when sending messages.Before sending an MLS message, detect locally groups that have epoch 0, wipe them, and re-establish before encrypting and sending the message.
This PR also adds a developer flag,
simulateUnestablishedMLSGroup, which leaves the next locally created MLS group at epoch 0 for manual reproduction and testing.Testing
simulateUnestablishedMLSGroup.Checklist
[WPB-XXX].UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: