Skip to content

fix: Recover unestablished MLS groups - WPB-21123#5040

Open
acv-w wants to merge 5 commits into
developfrom
fix/recover-unestablished-mls-group-WPB-21123
Open

fix: Recover unestablished MLS groups - WPB-21123#5040
acv-w wants to merge 5 commits into
developfrom
fix/recover-unestablished-mls-group-WPB-21123

Conversation

@acv-w

@acv-w acv-w commented Jul 21, 2026

Copy link
Copy Markdown
Contributor
BugWPB-21123 [iOS] Recover from having a local unestablished MLS group

Issue

An MLS conversation can remain in Core Crypto at epoch 0. Because conversationExists still returns true, the client incorrectly treats it as established when sending messages.

Before sending an MLS message, detect locally groups that have epoch 0, wipe them, and re-establish before encrypting and sending the message.

This PR also adds a developer flag, simulateUnestablishedMLSGroup, which leaves the next locally created MLS group at epoch 0 for manual reproduction and testing.

Testing

  1. Enable simulateUnestablishedMLSGroup.
  2. Create an MLS group.
  3. Send the first message.
  4. Verify the (epoch-0) group is wiped, re-established, and the message is sent successfully.

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@acv-w
acv-w requested review from a team, David-Henner and netbe and removed request for a team July 21, 2026 16:28
@acv-w acv-w changed the title fix: Recover unestablished MLS groups - [WPB-21123] fix: Recover unestablished MLS groups - WPB-21123 Jul 21, 2026
@github-actions

github-actions Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Test Results

1 247 tests   1 247 ✅  49s ⏱️
  155 suites      0 💤
    2 files        0 ❌

Results for commit 678161a.

♻️ This comment has been updated with latest results.

Summary: workflow run #29901708326
Allure report (download zip): html-report-32192-fix_recover-unestablished-mls-group-WPB-21123

@acv-w
acv-w requested a review from a team July 21, 2026 17:16
@caldrian
caldrian requested review from a team, KaterinaWire and jullianm and removed request for a team, David-Henner and netbe July 22, 2026 07:56

@jullianm jullianm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acv-w
acv-w requested a review from johnxnguyen July 22, 2026 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants