chore: split WireNetwork into three packages - WPB-15347#5003
chore: split WireNetwork into three packages - WPB-15347#5003caldrian wants to merge 14 commits into
Conversation
Test Results0 tests 0 ✅ 0s ⏱️ Results for commit b0615b8. ♻️ This comment has been updated with latest results. Summary: workflow run #29099982608 |
Test Results – batch 1 1 files 142 suites 14s ⏱️ Results for commit 557a03f. ♻️ This comment has been updated with latest results. |
Test Results – batch 0196 tests 196 ✅ 13s ⏱️ Results for commit 557a03f. ♻️ This comment has been updated with latest results. |
…icate-symbols-WPB-15347
…icate-symbols-WPB-15347
|
| @@ -3,35 +3,15 @@ | |||
| import PackageDescription | |||
|
|
|||
| let package = Package( | |||
| name: "WireNetwork", | |||
| name: "WireNetworkTests", | |||
There was a problem hiding this comment.
question: why do we need a separate package for tests? A separate package for WireNetworkSupport makes sense, but I would expect that in WireNetwork there is simply a test target.
There was a problem hiding this comment.
If WireNetworkSupport is in a separate package, WireNetworkTests must be in a separate as well, otherwise we'd have a cyclic dependency, which is not allowed.
samwyndham
left a comment
There was a problem hiding this comment.
I think in practice 1 or 2 packages is enough. Some options include:
- Have a single
WireNetworkpackage with a single product containing multiple targets -WireNetwork&WireNetworkSupport. Also, update the automockable stencil so that mocks are generated inside anif DEBUG. I think this could be the easiest general approach to our project. This also means potentially using our mocks within SwiftUI previews which could be helpful. - Have 2 packages -
WireNetwork&WireNetworkSupport.WireNetworkTestsstill live inside theWireNetworkpackage but do not depend on theWireNetworkSupportpackage. Instead as the mocks are generated just them generated in bothWireNetworkTestsandWireNetworkSupport. - Have 2 packages -
WireNetwork&WireNetworkSupport.WireNetworkTestslives insideWireNetworkSupport- I don't like this option.
@caldrian what do you think?
|
removing myself from review since 2 reviewers are there already. Ping me if needed |


Issue
This PR attempts to prevent duplicate symbols of types in WireNetwork by splitting the framework into three packages each having only one dynamic product.
After merging the GitHub Actions caches should be cleared!
Checklist
[WPB-XXX].UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: