Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions charts/coturn/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,11 @@ externalIpHelper:
# important that they run on disjoint sets of nodes, you can use nodeSelector to enforce this
nodeSelector: {}

# Limiting memory usage to ~90% of the available memory on a 8Gb node which is used for coturn pods by default.
# This is to prevent the pod from being OOM kill
resources:
requests:
memory: 512Mi
memory: 256Mi
limits:
memory: 6.5Gi
memory: 512Mi

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we should be as agressive. A single coturn pod usually owns its node anyway and we should leave it up to the operator to set mem limits to whatever the node can tolerate.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main reason for this change is, that this limit is setting false expectations and lead to false sizing assumptions.
In prod, there is no coturn pod that is using more than 150mb. If a customer is sizing their coturn nodes, and they are driven by the limits here, the will be way too big and are just inflating the compute requirements (which especially on-prem need to be really tailored to what we need)
One can always overwrite the limits of course, but from my perspective the standard should reflect the reality.
Wdyt?


initResources:
requests:
Expand Down