feat(migrations): assert UTF8 database encoding at install - #68
Merged
Conversation
A Postgres database that is not UTF8 rejects every non-ASCII byte at write time, poisoning commit batches long after install. The first migration now asserts the contract and refuses a misprovisioned database with the reason spelled out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Observed in production: a SQL_ASCII-encoded database accepted an install and then rejected every non-ASCII byte at write time — one poisoned commit batch at a time, long after day one (pq: conversion between UTF8 and SQL_ASCII is not supported).
A migration cannot re-encode a database, but it can refuse one: the new first migration (timestamp before 01) asserts pg_encoding = UTF8 on Postgres and fails with the fix spelled out. SQLite stores byte sequences verbatim and is not asserted.
Tests: 968 sqlite green; the postgres CI matrix runs the guard against a UTF8 database.