Skip to content

Show which clips are in play in the arrange view too #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
willkotheimer merged 1 commit into from
Sep 12, 2026
Merged

Show which clips are in play in the arrange view too #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/renderer/components/ArrangeList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,14 @@ import { moveClip, sourceLabel } from '../helpers/ArrangeListHelper'
export function ArrangeList({
clips,
cursorClipId,
hasSelection,
onChange,
onDelete
}: {
clips: readonly ClipView[]
cursorClipId: string | null
/** Whether a subset is in play, so the rows can show it the way the compact list does. */
hasSelection: boolean
onChange: (clipIds: string[]) => void
onDelete: (clipId: string) => void
}): JSX.Element {
Expand Down Expand Up @@ -75,6 +78,8 @@ export function ArrangeList({
clip={clip}
position={index + 1}
isNext={clip.id === cursorClipId}
chosen={hasSelection && clip.isSelected}
out={hasSelection && !clip.isSelected}
onMove={(direction) => onChange(moveClip(ids, index, index + direction))}
onDelete={() => onDelete(clip.id)}
/>
Expand All @@ -89,12 +94,17 @@ function Row({
clip,
position,
isNext,
chosen,
out,
onMove,
onDelete
}: {
clip: ClipView
position: number
isNext: boolean
/** Lit and receded as in the compact list, so the two views never disagree about what is in play. */
chosen: boolean
out: boolean
onMove: (direction: -1 | 1) => void
onDelete: () => void
}): JSX.Element {
Expand All @@ -109,7 +119,9 @@ function Row({
style={{ transform: CSS.Transform.toString(transform), transition }}
className={[
'flex items-center gap-2 rounded border px-2 py-1.5',
isNext ? 'border-spool-thread/60 bg-spool-thread/10' : 'border-spool-paper/10',
isNext ? 'border-spool-thread/60' : 'border-spool-paper/10',
chosen ? 'bg-spool-paper/10' : isNext ? 'bg-spool-thread/10' : '',
out ? 'opacity-40' : '',
isDragging ? 'opacity-60' : ''
].join(' ')}
>
Expand Down
6 changes: 5 additions & 1 deletion src/renderer/components/ExpandedView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,11 @@ export function ExpandedView({

<div className="flex min-h-0 flex-1">
<section className="min-h-0 flex-1 overflow-y-auto px-4 py-3">
<ArrangeList clips={orderedClips} cursorClipId={spool.cursorClipId} onChange={setDraft}
<ArrangeList
clips={orderedClips}
cursorClipId={spool.cursorClipId}
hasSelection={spool.hasSelection}
onChange={setDraft}
onDelete={(clipId) => void window.spool.deleteClip(clipId)}
/>
</section>
Expand Down
Loading