🔒 Security: Fix reentrancy in MyToken transfer and transferFrom#55
Open
canychan wants to merge 1 commit into
Open
🔒 Security: Fix reentrancy in MyToken transfer and transferFrom#55canychan wants to merge 1 commit into
canychan wants to merge 1 commit into
Conversation
|
Hi! Professional smart contract auditor with 32+ findings. Portfolio: https://ajarcoronet5415-commits.github.io/security-audit-portfolio/ - AGX |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔒 Security Fix
Vulnerability: Reentrancy in ERC223 tokenFallback during transfer and transferFrom
Severity: CRITICAL
Category: reentrancy
SWC: SWC-107
Description
In both "transfer()" and "transferFrom()", the external call to "tokenFallback()" on the recipient contract was performed BEFORE updating the internal balances. This violates the Checks-Effects-Interactions pattern and allows a malicious receiving contract to reenter and drain tokens.
Fix
Checklist
This PR was submitted by an automated security audit system. Please review carefully.