Trust only configured proxies for forward proxy authentication#36
Open
3em0 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #33.
This adds an explicit trust boundary for Forward Proxy Authentication headers. Isaiah now accepts the configured proxy authentication header only when the websocket request comes from an IP address listed in
FORWARD_PROXY_AUTHENTICATION_TRUSTED_PROXIES.Changes
FORWARD_PROXY_AUTHENTICATION_TRUSTED_PROXIESas a comma-separated IP/CIDR allowlist.Testing
git diff --checkgofmt/go test ./...because this environment does not have the Go toolchain installed (goandgofmtare unavailable).