Create tables via kura migrations on boot; drop schema sql#32
Merged
Conversation
- run kura_migrator:migrate/1 in chatli_app:start so chatli creates its own tables on boot; commit the generated migration - remove schema sql (sql/10_ldf.sql, sql/20_chatli.sql); the demo no longer needs them - remove misplaced li/ldf_message schemas (those tables belong to ldf) - docker-compose provides an empty chatli DB; sql/seed.sql holds the sample users, applied after boot (data-only, ON CONFLICT DO NOTHING) CT suite (all 12) passes against a migrated + seeded DB.
Prevents local _build (OTP-specific plugin beams) from being copied into the Docker build and failing the release with beam load errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes chatli fully kura-native.
Changes
kura_migrator:migrate(chatli_repo)inchatli_app:startcreates tables on boot; commit the generated migration.sql/10_ldf.sql,sql/20_chatli.sql).li/ldf_messageschemas (those tables belong to ldf).sql/seed.sql(data-only, idempotent) holds the sample users, applied after boot; docker-compose serves an emptychatliDB..dockerignoreexcludes_build.Verification
Empty DB -> boot -> 7 tables created via migration; seed applied; all 12 CT tests pass. fmt/xref/lint clean.