Fix DM chat title showing the wrong username#6
Merged
Conversation
For 1-on-1 chats, chat.name is stored once at creation as the recipient's username from the creator's viewpoint, so the recipient saw their own name in the title. Derive the title per-viewer from the other participant instead, falling back to chat.name for group chats.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
For 1-on-1 chats, the messages page set the header from
chat.name. Butchat.nameis stored once at creation as the recipient's username from the creator's viewpoint (contacts.page.ts:56sendsname: user.username). It's a fixed string on the chat row, not per-viewer:name = "bob"Fix
Derive the title per-viewer from the participant list (the server returns the other participants; the current user is appended client-side afterward). For a
1to1chat with one other participant, use that participant'susername; otherwise fall back tochat.name(group chats are unaffected). Extracted into achatTitle()helper used by both the initial load and the post-invite update.Verification
npm run lint- passesnpm run build- succeeds