chore(otp): build on OTP 29#60
Merged
Merged
Conversation
OTP 29 deprecates `catch Expr` (hard error under warnings_as_errors). - .tool-versions: erlang 29.0.2 (now tracked + un-ignored; drives CI via version-file) - ci.yml / nightly.yml: use version-file '.tool-versions' instead of hardcoded otp-version - meck ~> 0.9 -> ~> 1.2 (0.9 fails to compile on OTP 29) - test profile: nowarn_deprecated_catch (test teardown uses catch; src is catch-free) Verified green on OTP 29.0.2 against asobi's fixed branch: compile, eunit 223/0, dialyzer. NOTE: the asobi pin must be bumped to main once widgrensit/asobi#138 merges (asobi v2.0.8 kura). Draft until then.
Flip the asobi pin to main now that widgrensit/asobi#138 is merged. Green on OTP 29.0.2: compile, eunit 223/0, dialyzer.
Taure
marked this pull request as ready for review
June 30, 2026 10:05
cowboy 2.15.0 pins cowlib 2.16.1 transitively, which the GitHub Advisory DB now flags (LOW, CVE-2026-43969). Promote cowlib to the patched ~> 2.17 (hex cowboy 2.15.0 is compatible with cowlib 2.17.1, per asobi_engine). Real fix instead of an audit-ignore. eunit 223/0 on OTP 29.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft — blocked on widgrensit/asobi#138.
OTP 29 deprecates
catch Expr. asobi_lua's own code is catch-free; the work is toolchain + test deps:.tool-versionserlang 29.0.2 (un-ignored + tracked, mirroring asobi/engine/saas), CI viaversion-file~> 0.9→~> 1.2; test profilenowarn_deprecated_catchVerified green on OTP 29.0.2 (compile, eunit 223/0, dialyzer) against asobi's
chore/otp-29branch.Flip step once #138 merges:
rebar3 upgrade asobi(pulls asobi main with kura v2.0.8), re-verify, mark ready. (CT is pre-existing broken on a.srcsys_config consult — OTP-independent, out of scope.)