chore(qa): luacheck/stylua config + validate realtime event names#19
Closed
Taure wants to merge 1 commit into
Closed
chore(qa): luacheck/stylua config + validate realtime event names#19Taure wants to merge 1 commit into
Taure wants to merge 1 commit into
Conversation
- Add .luacheckrc with Defold runtime globals and per-tree ignore rules - Add .stylua.toml (tabs, 100-col, double quotes) and apply to all Lua - Validate event names in asobi.realtime:on so callback typos raise at registration time instead of silently never firing - Add typo regression test in tests/test_dispatch.lua - Sweep em dashes -> ASCII hyphens in changed prose - Underscore unused args in Defold callback signatures (http.lua, realtime.lua) - Ignore .claude/ per-user state luacheck: 0/0 across 23 files. stylua --check: clean. 34/34 dispatch tests pass.
Taure
force-pushed
the
chore/lint-format-config
branch
from
May 2, 2026 09:30
a0195df to
2141c55
Compare
Taure
added a commit
that referenced
this pull request
Jul 20, 2026
M:on/2 accepted any string, so a typo registered a callback that could never fire - indistinguishable from the server not sending the event. KNOWN_EVENTS is derived from SERVER_EVENTS plus the events realtime.lua fires directly, so a new wire event cannot be registerable-but-unlisted. Idea from #19, written fresh: that branch's list omitted auth_expired and world_terrain.
Contributor
Author
|
Closing. The luacheck config landed on main independently, and this branch is three months old with six conflicts against files changed since — including today's API sync (#29), which rewrote The durable idea here was event-name validation, and that is now on main via #30. It was written fresh rather than ported for a specific reason: the
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.luacheckrc(Defold runtime globals + per-tree ignore rules) and.stylua.toml(tabs, 100-col, double quotes); apply stylua to all Lua source.asobi.realtime:onagainst a known-events set so callback typos raise at registration time instead of silently never firing — protects users during the breaking per-instance API rollout.tests/test_dispatch.lua(rejectsmatch_mached, acceptsentity_added).asobi/http.lua,asobi/realtime.lua)..claude/per-user state.Verification
luacheck: 0 warnings / 0 errors across 23 files.stylua --check: clean.tests/test_dispatch.lua: 34 passed, 0 failed (32 fixtures + 2 KNOWN_EVENTS assertions).tests/test_entity_sync.lua: all entity-sync tests passed.Test plan
sdk_demo_backend(runs in GitHub Actions)