refactor: remove dead deploy-key scaffolding (CLI)#26
Merged
Conversation
asobi deploy is a pull model: the CLI uploads the bundle to saas over its Bearer access token (auth.DeployBundle), saas stores it, and the engine pulls its own bundle with x-engine-key. The CLI never holds an engine credential. These paths were orphaned (no callers): - main.go: resolveDeployCredentials, cmdDeployEphemeral - auth/saas.go: MintKey, EphemeralDeploy (+ their response types) - client/client.go: Client.Deploy, DeployRequest, DeployResponse (kept Script, used by internal/deploy) - auth/device_test.go: the two MintKey tests Removes the ephemeral cli_deploy key-mint client surface. build/vet/test green. First step of the credential-model cleanup (server-side mint/ validate routes follow).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR1 of the credential-model cleanup.
asobi deployis a pull model - the CLI uploads the bundle to saas over its Bearer access token (auth.DeployBundle), saas stores it, and the engine pulls its own bundle via/internal/bundlewithx-engine-key. The CLI never holds an engine credential, so the direct-to-engine deploy + ephemeral-key-mint paths are orphaned.Removed (all no callers)
cmd/asobi/main.go:resolveDeployCredentials,cmdDeployEphemeralinternal/auth/saas.go:MintKey,EphemeralDeploy(+ response types)internal/client/client.go:Client.Deploy,DeployRequest,DeployResponse(keptScript- used byinternal/deploy)internal/auth/device_test.go: the twoMintKeytestsKept (live)
DeployBundle,ListEnvs/ListEnvs2,CreateEnv,Destroy,RefreshAccessToken,Client.Health, and--ephemeralonenv list(a different, live env-listing feature).Verify
go build ./...,go vet ./...,go test ./...all green.First of 4 dead-code PRs; the matching saas
/internal/cli/mint-key+/ephemeral-deployroutes are removed in PR2 (merge this first).