fix(acp): migrate to maintained adapter packages#8
Merged
Conversation
fix: - Migrate Claude and Codex launchers to the Agent Client Protocol namespace - Upgrade the shared Docker Node.js runtime to version 22 feat: - Log ACP implementation and protocol metadata after initialization test: - Cover updated presets, Docker runtime, and missing agent metadata docs: - Document local Node.js requirements and runtime version logging
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
Clean migration to maintained ACP packages. Node.js 20→22 upgrade required by new Claude adapter. Agent identity logging is well-defended and tested. No issues found.
Severity: Critical 0 / High 0 / Medium 0 / Low 0
Inline comments posted: 0
Generated by whhe/code-review-bot · Agent: OpenCode · Skill fingerprint: 43b5df0c
Model: qwen3.7-max · Tokens: input 1,087 / output 63 / total 37,430
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrate the built-in Claude and Codex ACP launchers to the maintained Agent Client Protocol packages. Update the shared runtime and expose ACP implementation metadata in logs.
Changes
Motivation
The previous ACP packages are deprecated, and the current Claude adapter requires Node.js 22. Runtime logs also lacked the adapter version needed for diagnosing compatibility issues.