Skip to content

feat(review): enrich review attribution metadata#7

Merged
whhe merged 1 commit into
mainfrom
feature-review-comment-layout
Jul 21, 2026
Merged

feat(review): enrich review attribution metadata#7
whhe merged 1 commit into
mainfrom
feature-review-comment-layout

Conversation

@whhe

@whhe whhe commented Jul 21, 2026

Copy link
Copy Markdown
Owner

Summary

Improve review summary attribution by displaying the active agent and configured model metadata while preserving the existing ACP model-selection behavior. The attribution continues to link to whhe/code-review-bot.

Changes

  • Show the agent before the skill fingerprint and place model/token usage on the final visible line.
  • Use ACP_MODEL, ANTHROPIC_MODEL, or OPENCODE_MODEL as display-only model metadata with explicit precedence.
  • Preserve response model metadata as a fallback when no configured display model is available.
  • Keep the Generated by link pointed at the GitHub repository.
  • Update JSON retry generics for Python 3.12 Ruff compliance.
  • Document the display behavior and add coverage for precedence, agent labels, layout, and ACP isolation.
  • Verify the change with Ruff and the complete test suite (238 passed).

Motivation

ACP responses may omit the model name even when the backend model is explicitly configured, causing review comments to display unavailable. Review summaries also need to identify the active agent without changing how models are selected or configured.

feat:
- Show agent identity before the skill fingerprint in review summaries
- Prefer configured model names for display without changing ACP selection
- Preserve the GitHub repository attribution and place model usage last

fix:
- Update JSON retry generics for Python 3.12 Ruff compliance

docs:
- Document display-only model fallback behavior

test:
- Cover model precedence, agent labels, footer layout, and ACP isolation

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

Well-structured display-only enrichment of review attribution metadata. Changes are cleanly scoped, backward-compatible, and thoroughly tested.

Severity: Critical 0 / High 0 / Medium 0 / Low 0
Inline comments posted: 0

Model: unavailable · Tokens: input 4,557 / output 49 / total 38,655
Generated by whhe/code-review-bot · Skill fingerprint: 43b5df0c

@whhe
whhe merged commit 7a26fd1 into main Jul 21, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant