Surface runtime model + token usage in published review summaries - #6
Conversation
There was a problem hiding this comment.
Code Review
Clean runtime metadata propagation end-to-end with solid test coverage. Low overall risk; one minor type-check defensiveness improvement suggested.
Severity: Critical 0 / High 0 / Medium 0 / Low 1
Inline comments posted: 1
Generated by whhe/code-review-bot · Skill fingerprint: 43b5df0c
|
@copilot fix the comment #6 (comment) |
Fixed in commit 7f83bde. |
There was a problem hiding this comment.
Code Review
Clean implementation that propagates ACP runtime model and token usage end-to-end with well-designed aggregation semantics and good test coverage. No new issues found; the previously flagged bool/int edge case is fixed.
Severity: Critical 0 / High 0 / Medium 0 / Low 0
Inline comments posted: 0
Generated by whhe/code-review-bot · Skill fingerprint: 43b5df0c
Review outputs currently dropped runtime metadata collected by ACP, so maintainers could not see which model produced a review or the token cost of the run. This change propagates structured runtime metadata end-to-end and renders it in the final summary body (including consolidated GitHub review bodies) with explicit unavailable states.
Runtime metadata propagation
AgentRunResultnow carriesmodel; ACP runtime captures response-reported model when present.SkillResultnow carries attached runtime metadata (model,input_tokens,output_tokens,total_tokens).Usage aggregation at runner boundary
CodingAgentReviewRunneraggregates runtime data across all agent calls in a review run, including retry paths.Summary rendering updates
format_review_note(...)now renders a compact runtime footer line near bot attribution.