fix(review): align attribution and consolidate GitHub reviews#4
Merged
Conversation
fix: - Build the OpenCode review image from the exact pull request head - Attribute review comments to the bot and show the active skill fingerprint test: - Remove presentation-only assertions from repository tests docs: - Document the development-image self-review workflow
fix: - Pass docker/Dockerfile explicitly when building the OpenCode review image
Code ReviewLow risk. Self-review workflow correctly builds from PR source with same-repo guard and persist-credentials:false. One minor test coverage gap from a deleted negative-case assertion. Severity: Critical 0 / High 0 / Medium 0 / Low 1 Generated by whhe/code-review-bot · Skill fingerprint: |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
fix: - Publish the full summary as the GitHub approval decision body - Preserve metadata discovery and extension compatibility - Fall back to issue comments when review submission fails ci: - Restore the published OpenCode image for self-review test: - Cover review consolidation, fallback, pagination, and legacy contracts
whhe
changed the title
Code ReviewLow risk: well-structured consolidation of GitHub review body with strong backward compatibility. One medium concern: unprotected fallback publish_summary call. Existing open thread on missing negative-case test remains valid. Severity: Critical 0 / High 0 / Medium 1 / Low 0 Skill: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make review provenance explicit and avoid duplicate GitHub summary artifacts while retaining the published OpenCode image for the self-review workflow.
Changes
whhe/code-review-botand display the active skill fingerprint.APPROVEorREQUEST_CHANGESreview body when supported.whhe/code-review-bot:opencode.Motivation
The previous workflow could publish both a complete summary comment and a separate generic “Code review found new issues.” review. Consolidating them produces one authoritative review result without assuming a fixed review-skill URL or breaking extension implementations.
Validation
uv run pytest tests -q— 219 passeduv run ruff check src tests --ignore UP047.github/workflows/code-review.ymlwith PyYAMLgit diff --check