Repository navigation
👷 ci: integrate the reviewed tooling upgrades - #8
Merged
Merged
Conversation
Bumps [actions/upload-pages-artifact](https://github.com/actions/upload-pages-artifact) from 3.0.1 to 5.0.0. - [Release notes](https://github.com/actions/upload-pages-artifact/releases) - [Commits](actions/upload-pages-artifact@56afc60...fc324d3) --- updated-dependencies: - dependency-name: actions/upload-pages-artifact dependency-version: 5.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [actions/setup-node](https://github.com/actions/setup-node) from 4.4.0 to 7.0.0. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](actions/setup-node@49933ea...8207627) --- updated-dependencies: - dependency-name: actions/setup-node dependency-version: 7.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [actions/deploy-pages](https://github.com/actions/deploy-pages) from 4.0.5 to 5.0.1. - [Release notes](https://github.com/actions/deploy-pages/releases) - [Commits](actions/deploy-pages@d6db901...368f825) --- updated-dependencies: - dependency-name: actions/deploy-pages dependency-version: 5.0.1 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [actions/configure-pages](https://github.com/actions/configure-pages) from 5.0.0 to 6.0.0. - [Release notes](https://github.com/actions/configure-pages/releases) - [Commits](actions/configure-pages@983d773...45bfe01) --- updated-dependencies: - dependency-name: actions/configure-pages dependency-version: 6.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [actions/checkout](https://github.com/actions/checkout) from 4.4.0 to 7.0.1. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@11d5960...3d3c42e) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: 7.0.1 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [@playwright/test](https://github.com/microsoft/playwright) from 1.56.0 to 1.63.0. - [Release notes](https://github.com/microsoft/playwright/releases) - [Commits](microsoft/playwright@v1.56.0...v1.63.0) --- updated-dependencies: - dependency-name: "@playwright/test" dependency-version: 1.63.0 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Update the Pages upload upgrade with the validated main branch so its checks include the Linux artifact installer and PostgreSQL fixture repairs. Explicitly include hidden files from the allowlisted site build to preserve the existing .nojekyll marker under upload-pages-artifact v5. Reproduced the default and explicit GNU tar archives and confirmed that the marker is the only difference. Keep SHA pins, manual deployment and existing deployment permissions.
Bring dependency review PR 2 up to date with the validated main branch so its checks exercise the Linux npm layout, pinned PostgreSQL fixtures and corrected service health command. Preserve the proposed version upgrade and the existing code-owner approval policy. Reviewed the upstream release and exact source inputs; Playwright 1.63 separately passed the build, publication allowlist and all 67 browser tests. The updated pull request will run the complete remote validation before merge.
Bring dependency review PR 3 up to date with the validated main branch so its checks exercise the Linux npm layout, pinned PostgreSQL fixtures and corrected service health command. Preserve the proposed version upgrade and the existing code-owner approval policy. Reviewed the upstream release and exact source inputs; Playwright 1.63 separately passed the build, publication allowlist and all 67 browser tests. The updated pull request will run the complete remote validation before merge.
Bring dependency review PR 4 up to date with the validated main branch so its checks exercise the Linux npm layout, pinned PostgreSQL fixtures and corrected service health command. Preserve the proposed version upgrade and the existing code-owner approval policy. Reviewed the upstream release and exact source inputs; Playwright 1.63 separately passed the build, publication allowlist and all 67 browser tests. The updated pull request will run the complete remote validation before merge.
Bring dependency review PR 5 up to date with the validated main branch so its checks exercise the Linux npm layout, pinned PostgreSQL fixtures and corrected service health command. Preserve the proposed version upgrade and the existing code-owner approval policy. Reviewed the upstream release and exact source inputs; Playwright 1.63 separately passed the build, publication allowlist and all 67 browser tests. The updated pull request will run the complete remote validation before merge.
Bring dependency review PR 6 up to date with the validated main branch so its checks exercise the Linux npm layout, pinned PostgreSQL fixtures and corrected service health command. Preserve the proposed version upgrade and the existing code-owner approval policy. Reviewed the upstream release and exact source inputs; Playwright 1.63 separately passed the build, publication allowlist and all 67 browser tests. The updated pull request will run the complete remote validation before merge.
Verify offline report preferences by reloading the same file without a clearing initialization script. Add an independent cross-tab assertion for the actual generated report served through a defined HTTP origin. Chromium file-origin storage sharing is unspecified and the former new-tab assumption failed on both Playwright versions in Linux CI. Preserve default language, system theme, saved preferences and cross-tab coverage. The corrected persistence and keyboard cases passed 30 repeated local checks.
Wait until React has rendered the skip link before sending the first Tab key in the documentation accessibility test. Page load can finish before the asynchronous root render, causing keyboard input to arrive while no application link exists. Keep the actual Tab and Enter interactions and the focus and route assertions. The corrected keyboard and persistence cases passed 30 repeated checks; no timing sleeps or retries were added.
Verify offline report preferences by reloading the same file without a clearing initialization script. Add an independent cross-tab assertion for the actual generated report served through a defined HTTP origin. Chromium file-origin storage sharing is unspecified and the former new-tab assumption failed on both Playwright versions in Linux CI. Preserve default language, system theme, saved preferences and cross-tab coverage. The corrected persistence and keyboard cases passed 30 repeated local checks.
Wait until React has rendered the skip link before sending the first Tab key in the documentation accessibility test. Page load can finish before the asynchronous root render, causing keyboard input to arrive while no application link exists. Keep the actual Tab and Enter interactions and the focus and route assertions. The corrected keyboard and persistence cases passed 30 repeated checks; no timing sleeps or retries were added.
Merge reviewed PR #4 into the combined tooling branch. Resolve the adjacent Pages action conflict by retaining configure-pages v6.0.0 and upload-pages-artifact v5.0.0 together. Preserve the explicit hidden-file flag after the existing publication allowlist. Validate the complete combined result before the maintainer-authorized main merge.
Integrate reviewed PR #5 into the combined tooling branch. Retain the SHA-pinned checkout v7.0.1 action alongside the reviewed Node 24 setup action and existing disabled credential persistence. Validate all reviewed tooling changes together before the maintainer-authorized main merge.
Integrate reviewed PR #6 into the combined tooling branch. Retain Playwright 1.63.0 and its exact lockfile with the reviewed offline preference and keyboard focus tests. Preserve the matching test corrections already introduced by PR #3 and validate the combined action and browser upgrades before the maintainer-authorized main merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade the SHA-pinned GitHub Actions tooling and Playwright browser coverage together. Preserve the static publication allowlist, explicit hidden-file inclusion and disabled checkout credential persistence. Correct report persistence and keyboard tests using the already reviewed changes from PRs #3 and #6.
This integrates the exact reviewed heads of #1, #2, #3, #4, #5 and #6 with merge commits. The only integration conflict involved adjacent configure-pages and upload-pages-artifact lines; both new pins are retained. An automated content comparison verified the two workflows contain only the reviewed pin/input changes and that the manifest, lockfile and browser tests match the reviewed Playwright proposal exactly.
All six individual proposals passed both push and pull-request workflows, including live PostgreSQL 14.20, 15.15, 16.11, 17.7 and 18.1. The two affected suites passed all 68 browser tests on Linux. The combined branch receives the same complete validation before the maintainer-authorized merge.
Pages publication remains manual. This PR does not trigger a deployment or publish a new release.