test(cli): Hardener SHOULDs 3–6 prove-red - #3396
Merged
Merged
Conversation
…dBox / orphan) Lock residual gaps on tip ebb48e5: browser unloadable ignore, WARN soft-fail copy, guides that still teach vacuous exit 0, CommandBox test runners that swallow failing exits, and unrouted Tests.cfc. Signed-off-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Peter Amiri <peter@alurium.com>
…drop orphan Tests.cfc SHOULD 3 residual: $browserTestResultFailed takes specsFailedToLoad; WARN no longer says silently skipped. SHOULD 4: guides name Wheels.TestsFailed. SHOULD 5: CommandBox test runners error() instead of swallowing TestBox exits. SHOULD 6: delete unrouted Tests.cfc. Signed-off-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Peter Amiri <peter@alurium.com>
Tip already fail-closes compile-skip via $countSpecsFailedToLoad and $throwIfCliTestsFailed. Restore those helpers and the WARN copy. Signed-off-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Peter Amiri <peter@alurium.com>
CommandBox error() does not abort. Specs now require no testbox run and return immediately after the deprecation error(). Signed-off-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Peter Amiri <peter@alurium.com>
error() does not abort. Each frozen test runner now returns immediately and no longer invokes testbox run (C5). Signed-off-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Peter Amiri <peter@alurium.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #3083.
Peter standing rule: finish the WheelsTest review SHOULDs. C1 / SHOULD 3 not reopened. C5 (CommandBox
error()does not abort) prove-red at28e2e9c92, green ate074c5265.Filter / URL:
GET http://localhost:8080/wheels/cli/tests?format=json. Isolatecli.lucli.tests.specs.commands.TestExitFailClosedSpecandcli.lucli.tests.specs.commands.HardenerShouldsSpecinbundleStats.*Spec.cfcWARN → fail-closed#3395, not reopened)ebb48e5a1:$countSpecsFailedToLoad→$cliTestResultFailed/$throwIfCliTestsFailed.TestExitFailClosedSpecits: "flags unloadable specs (specsFailedToLoad > 0)" and "throws Wheels.TestsFailed when specsFailedToLoad > 0". C1 (directoryRejected/bundlesDiscovered=0) left on tip. EmptytestDirectoryis not a live gap (runTestsalways setsresolvedDir). WARN copy still says "silently skipped" then the throw seam fires — not a soft-fail.HardenerShouldsSpecSHOULD 4: guides nameWheels.TestsFailed/directoryRejected/bundlesDiscovered.quick-start.mdxno longer says a run with no failures exits 0.error()does not abort28e2e9c92:findNoCase("testbox run", src) == 0anderror("DEPRECATED..."); return;failed whilerun.cfcstill calledcommand("testbox run")aftererror(). Greene074c5265: each frozen runnererror()thenreturn;with notestbox run. Same for all / unit / integration / coverage / watch / browser:test.vendor/wheels/controllers/Tests.cfc/wheels/core/tests→public##tests_testbox,/wheels/app/tests→wheels##public##testbox.Required CI checks
cli/lucli/**andweb/sites/guides/**)Does not close.