Support filtering VariantDescription values - #137
Open
mgorny wants to merge 5 commits into
Open
Conversation
Signed-off-by: Michał Górny <mgorny@quansight.com>
Signed-off-by: Michał Górny <mgorny@quansight.com>
Make `get_variants_by_priority()` return a dictionary with both the label (for backwards compatibility) and the filtered properties. This will be needed by reverse dependencies to get the correct environment markers. Signed-off-by: Michał Górny <mgorny@quansight.com>
Make `check_variant_supported()` return a filtered `VariantDescription` when the variant is supported, or `None` otherwise. This provides the data needed for environment marker processing, while preserving boolean logic compatibility with `True` and `False`. Signed-off-by: Michał Górny <mgorny@quansight.com>
While technically a dict is ordered in Python, it is messy to rely on that, and we really need things in order. Signed-off-by: Michał Górny <mgorny@quansight.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an explicit function to filter through the values in
VariantDescription, and a kwarg to enable filtering in the big filtering and filtering+sorting functions.That's my limit for today, I'll tackle integration with api later.