Skip to content

Define opaque-response blocking (updated)#1755

Open
sefeng211 wants to merge 5 commits into
whatwg:mainfrom
sefeng211:sefeng/orb
Open

Define opaque-response blocking (updated)#1755
sefeng211 wants to merge 5 commits into
whatwg:mainfrom
sefeng211:sefeng/orb

Conversation

@sefeng211

@sefeng211 sefeng211 commented May 27, 2024

Copy link
Copy Markdown

This PR is based on what @annevk has proposed in #1442, with additional changes. It includes the validate a partial response and the Content-Range header parser algorithm, plus the additional changes that Firefox has made in its implementation.

#1442 had some discussions and references, and I wish I can keep them, but I don't have write access to annevk/orb, hence this PR. Please let me know if there's a better way to move this forward.

cc @zcorpan @annevk


TODO:

  • Define "validate a partial response" (and Content-Range header parser)
  • "ParseText" vs "create a classic script" + mock data
  • A PR against HTML is needed to ensure it passes the appropriate metadata for media element and classic script requests.
  • Double check this operates on the internal response (and if not pass it)
  • Also use response in encoding extraction, depends on Add algorithm to extract an encoding from a MIME type #1447
  • https://github.com/annevk/orb/labels/mvp
  • PR to make tests non-tentative

(See WHATWG Working Mode: Changes for more details.)


💥 Error: 422 Unprocessable Entity 💥

PR Preview failed to build. (Last tried on Jun 22, 2026, 1:15 PM UTC).

More

PR Preview relies on a number of web services to run. There seems to be an issue with the following one:

🚨 Spec Generator - Spec Generator is the web service used to build bikeshed/ReSpec specs

🔗 Related URL

Error output:

[
    {
        "lineNum": "4584:5",
        "messageType": "fatal",
        "text": "Saw a <th> that wasn't in a <tr>"
    },
    {
        "lineNum": "4585:5",
        "messageType": "fatal",
        "text": "Saw a <th> that wasn't in a <tr>"
    },
    {
        "lineNum": "9176:177",
        "messageType": "fatal",
        "text": "Saw a heading end tag </h2>, but the current open heading is <h3> (at 9176:1)."
    },
    {
        "lineNum": "9341:3",
        "messageType": "fatal",
        "text": "Saw an end tag </div>, but there were unclosed elements remaining before the nearest matching start tag (at 9322:3).\nOpen tags: <dl> at 9285:1, <dd> at 9287:2, <div> at 9322:3, <ol> at 9323:4"
    },
    {
        "lineNum": "9391:3",
        "messageType": "fatal",
        "text": "Saw an end tag </div>, but there were unclosed elements remaining before the nearest matching start tag (at 9369:3).\nOpen tags: <dl> at 9285:1, <dd> at 9345:2, <div> at 9369:3, <ol> at 9370:4"
    },
    {
        "lineNum": "637:23",
        "messageType": "link",
        "text": "Obsolete biblio ref: [rfc8941] is replaced by [rfc9651]. Either update the reference, or use [rfc8941 obsolete] if this is an intentionally-obsolete reference."
    },
    {
        "lineNum": "5374:7",
        "messageType": "link",
        "text": "No 'dfn' refs found for 'object' with for='['blob URL entry']'."
    },
    {
        "lineNum": "5380:62",
        "messageType": "link",
        "text": "No 'dfn' refs found for 'object' with for='['blob URL entry']'."
    },
    {
        "lineNum": null,
        "messageType": "failure",
        "text": "Did not generate, due to errors exceeding the allowed error level."
    }
]

This seems to be an issue with the Spec Generator service. PR Preview doesn't manage this service and so has no control over it. If you've identified an issue with it, you can report the issue to the maintainers of Spec Generator directly. Please be courteous. Thank you!

If you don't have enough information above to solve the error by yourself or if the issue doesn't seem related to Spec Generator, you can file an issue with PR Preview.

@zcorpan

zcorpan commented May 27, 2024

Copy link
Copy Markdown
Member

From the build errors, it looks like mimesniff needs to export more terms, e.g. https://github.com/whatwg/mimesniff/blob/main/mimesniff.bs#L988

sefeng211 added a commit to sefeng211/mimesniff that referenced this pull request Jun 11, 2024
I'd like to reference them in whatwg/fetch#1755,
hence this patch to export those two algorithms.
zcorpan pushed a commit to whatwg/mimesniff that referenced this pull request Jun 12, 2024
annevk and others added 4 commits June 12, 2024 14:32
This is good enough for early review, but there are a number of issues that still need resolving: https://github.com/annevk/orb/labels/mvp.

There are also some inline TODO comments.

A PR against HTML is needed to ensure it passes the appropriate metadata for media element and classic script requests. We might also want to depend on HTML for parsing JavaScript.
Comment thread fetch.bs Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants