Skip to content

📦 new: add Clean Workflow plugin branding - #15

Merged
warengonzaga merged 1 commit into
devfrom
feature/plugin-branding
Oct 3, 2026
Merged

warengonzaga merged 1 commit into
devfrom
feature/plugin-branding

Conversation

@warengonzaga

Copy link
Copy Markdown
Member

Adds the approved option C artwork to the plugin so Codex can load a custom composer icon and light/dark listing logos. The existing Clean Workflow presentation name and stable clean-workflow identifiers remain unchanged; the installed metadata already contained the correct name.

The change adds five small SVG masters, wires the three supported image fields, and documents artwork use plus the exact host verification boundary. No skill content, release version, or marketplace identity changes.

Refs #10. This PR does not auto-close it because actual installed-UI screenshot acceptance remains pending.

Validation

  • SVG structure/small-size/light/dark previews inspected; all five SVG audits passed without failures.
  • Manifest paths, square asset dimensions, skill frontmatter, relative links, unchanged bundled skills, and git diff --check passed.
  • White/green contrast: 5.20:1; mint/dark contrast: 10.88:1.
  • Supported CLI install: stable baseline → same-version candidate update → fresh candidate installation passed. All three image fields and exact installed asset bytes verified; all skill contents unchanged. Temporary marketplace/plugin removed; original configuration, marketplace list, and production cache verified unchanged.
  • Local-marketplace metadata points to source assets; installed-cache files were independently compared, not inferred from those paths.

Remaining acceptance evidence

Tested host: Codex 26.930.21537 (12776), runtime 0.159.0-alpha.12.1. Direct computer-use access to Codex is blocked by the tool, so actual installed card/detail/composer screenshots in both appearances are not verified. Metadata parsing and rendered artwork previews are not presented as desktop screenshot proof. A manual check is documented in docs/plugin-branding.md.

Copilot AI balanced review requested due to automatic review settings October 3, 2026 10:20

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The manifest paths, assets, and documentation are consistent, with pending installed-UI evidence clearly scoped as follow-up work.

Review effort: Balanced
Findings: None

What changed in this PR

Adds Clean Workflow branding assets and connects them to Codex plugin metadata while preserving existing identifiers.

Changes:

  • Adds five SVG branding variants.
  • Configures composer, light, and dark artwork.
  • Documents branding usage and verification limitations.
File Description
.codex-plugin/​plugin.json Connects supported image fields.
README.md Displays and documents branding.
docs/​plugin-branding.md Records metadata and verification boundaries.
assets/​README.md Documents artwork usage and palette.
assets/​icon.svg Adds the tiled composer icon.
assets/​logo.svg Adds the light-background logo.
assets/​logo-dark.svg Adds the dark-background logo.
assets/​logo-black.svg Adds monochrome dark artwork.
assets/​logo-white.svg Adds reversed monochrome artwork.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@warengonzaga

Copy link
Copy Markdown
Member Author

No actionable findings in the reviewed nine-file scope at f49fb0cbbd5809e45cc28c630a085cbb7548a2b3, against dev at d731216192f9509b3032ea14b23c8255eedb83c4.

Clean Code Review was completed after Copilot's exact-head review finished with no findings. The manifest changes only add supported artwork paths; stable names, displayName, and bundled skills are unchanged. Independent review found no correctness or maintainability issues in the scoped diff.

Validation passed: five SVG audits; rendered light/dark and small-size previews; manifest paths/dimensions; local documentation links and skill frontmatter; whitespace checks; and isolated baseline installation → same-version update → fresh candidate installation. Installed artwork bytes and skill contents matched the source. Temporary installation cleanup preserved the original configuration, marketplaces, and production plugin cache.

GitHub reports CLEAN/MERGEABLE. There are no unresolved review threads, requested reviews, enforced branch checks, or active observed bot runs. No fixes or thread resolutions were necessary.

Remaining acceptance evidence: actual installed Codex card/detail/composer screenshots are unavailable because the computer-use tool rejects access to Codex. Metadata and artwork previews do not prove those pixels or UI caching. Issue #10 remains open for the documented manual check; the complete issue is not claimed finished. This is a review comment, not an approval, merge, or release.

@warengonzaga warengonzaga self-assigned this Oct 3, 2026
@warengonzaga warengonzaga added enhancement [Type] New feature or improvement to existing functionality [issues, PRs] and removed enhancement labels Oct 3, 2026
@warengonzaga
warengonzaga merged commit fc7f206 into dev Oct 3, 2026
1 check passed
@warengonzaga
warengonzaga deleted the feature/plugin-branding branch October 3, 2026 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement [Type] New feature or improvement to existing functionality [issues, PRs]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants