feature(teamwork): task selection#34
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: d004734 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
5cad633 to
6e984ff
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an MVP for Teamwork pinned task lists with keyboard task selection + open-in-browser, and enriches task metadata (assignees/due date/board column/priority) by resolving workflow stages via a disk-cached lookup.
Changes:
- Adds pinned-task selection/navigation in the Teamwork Project tab (↑/↓ to move, Enter/Ctrl+O to open).
- Expands
getTeamworkTaskListTasks()normalization to include assignees, due date normalization, priority, and workflow-stage name/color resolution viagetWorkflowStageNames(). - Refactors/extends tests, adds helper utilities + inspection script/spec fixtures, and updates phase plan docs + changeset.
Reviewed changes
Copilot reviewed 42 out of 42 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/tui/teamwork.test.ts | Adds tests for pinned-task selection ordering and cycling helpers. |
| tests/teamwork/task-list-tasks.test.ts | Updates task-list task tests for richer normalized task metadata + workflow stage resolution. |
| tests/teamwork/project-metadata.test.ts | Refactors to shared Teamwork test helpers and temp cache dir utility. |
| tests/helpers/teamwork.ts | New shared test helpers: auth mock, fetch mock, temp cache dir management. |
| tests/cli/commands/teamwork.test.ts | Updates CLI output expectations to include task metadata lines. |
| src/utils/browser.ts | Adds doc comment for browser-open helper. |
| src/tui/pages/teamwork/project-tab.tsx | Implements pinned-task selection state, scrolling into view, keybindings, and open-selected-task behavior. |
| src/tui/pages/teamwork/my-work-tab.tsx | Adds placeholder doc comment. |
| src/tui/pages/teamwork.tsx | Updates status bar hints to include task navigation/open hints on Project tab. |
| src/tui/pages/settings/user-config-section.tsx | Adds section doc comment. |
| src/tui/pages/settings/types.ts | Adds doc comments clarifying Settings form state/types. |
| src/tui/pages/settings/project-links-section.tsx | Adds section doc comment. |
| src/tui/pages/settings/project-config-section.tsx | Adds section doc comment. |
| src/tui/pages/settings/pinned-task-lists-section.tsx | Adds section doc comment. |
| src/tui/pages/settings.tsx | Adds doc comments for parsing/validation/focus helpers. |
| src/tui/components/teamwork/task-metadata.tsx | New component to render task metadata (assignees/due/board/priority). |
| src/tui/components/teamwork/task-list.tsx | Adds selection highlighting and renders TaskMetadata per task. |
| src/tui/components/status-bar.tsx | Adds doc comments for hint types/provider. |
| src/tui/components/state-provider.tsx | Adds doc comments for state context/provider. |
| src/tui/components/layout/scroll-context.tsx | Adds doc comments for scroll provider/context access. |
| src/tui/components/layout/accordion-section.tsx | Adds doc comments for accordion component/props. |
| src/tui/components/forms/dynamic-list.tsx | Adds doc comments for dynamic list component/props. |
| src/teamwork/workflow-stages.ts | New cached workflow-stage lookup used to resolve board column name/color. |
| src/teamwork/tasks.ts | Adds doc comments for task reference parsing. |
| src/teamwork/task-list-tasks.ts | Expands task schema parsing + normalization to include metadata and workflow stage resolution. |
| src/teamwork/project-metadata.ts | Adds doc comments around project metadata types/API. |
| src/teamwork/consts.ts | Converts comment to doc comment and adds const doc comments. |
| src/teamwork/client.ts | Adds doc comment for API JSON fetch helper. |
| src/teamwork/auth.ts | Adds doc comments for auth/token helpers. |
| src/state/schema.ts | Adds doc comments for persisted TUI state schema/types. |
| src/config/templates.ts | Adds richer doc comments + examples for YAML template formatters. |
| src/cli/commands/teamwork.ts | Adds CLI formatting for task metadata + doc comments on commands. |
| src/cli/commands/config.ts | Adds doc comments for auth config commands/types. |
| src/cli/commands/cache.ts | Adds doc comment for cache clean command. |
| scripts/inspect-teamwork-task-fields.ts | New diagnostic script to inspect real Teamwork task/list/workflow fields. |
| plans/teamwork/5.2-pinned-project-task-lists.md | Updates phase plan with status and field verification notes/checklist. |
| plans/teamwork/5.1-foundation.md | Marks phase complete and updates checklist/status. |
| plans/PLAN.md | Marks Teamwork subphases with status indicators. |
| .changeset/ready-rivers-crash.md | Adds changeset entry for the feature. |
| _specs/workflow-200-ok.json | Adds Teamwork workflow spec fixture. |
| _specs/tasklist-200-ok.json | Adds Teamwork tasklist spec fixture. |
| _specs/task-200-ok.json | Adds Teamwork task spec fixture. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This adds a small MVP for task lists with navigation and hotkeys.
Type of Change
Local Verification
bun run fmtbun run lintbun run checkbun testbun run buildRelease Impact
.changeset/