chore(Deps): updating types and packages#82
Open
VrajVed wants to merge 1 commit into
Open
Conversation
| category: NodeCategory; | ||
| /** Zod schema for validating input */ | ||
| inputSchema: z.ZodSchema<TInput>; | ||
| inputSchema: z.ZodType<TInput, z.ZodTypeDef, any>; |
There was a problem hiding this comment.
[🟡 Medium] [🟡 Investigate]
The package still declares zod: ^3 || ^4 peer compatibility, but the updated node typing now references z.ZodTypeDef directly in public generic signatures; this type is tied to Zod internals/version surface and may fail for v4 consumers depending on the exact exported type aliases, causing downstream TypeScript errors when defining nodes. Validate by typechecking @jam-nodes/core and a minimal consumer against Zod v4, and if it fails, switch these public signatures to a version-agnostic generic form (e.g., avoid hard-coding ZodTypeDef in exported contracts).
// packages/core/src/utils/define-node.ts
inputSchema: z.ZodType<TInput, z.ZodTypeDef, any>;
/** Zod schema for validating output */
outputSchema: z.ZodType<TOutput, z.ZodTypeDef, any>;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue
AI summary
Problem: Build failed with 29 errors across packages/nodes and packages/playground-web. Root causes: zod v4 hoisted from root package.json but workspace packages target v3 APIs; @jam-nodes/core resolved to published npm package instead of local workspace (missing apify, googleSheets, slack credential types); missing @types/node; and several latent code issues masked by cascading type errors.
Changes: