Skip to content

chore(Deps): updating types and packages#82

Open
VrajVed wants to merge 1 commit into
wespreadjam:mainfrom
VrajVed:main
Open

chore(Deps): updating types and packages#82
VrajVed wants to merge 1 commit into
wespreadjam:mainfrom
VrajVed:main

Conversation

@VrajVed

@VrajVed VrajVed commented Jul 17, 2026

Copy link
Copy Markdown

issue

image

AI summary

Problem: Build failed with 29 errors across packages/nodes and packages/playground-web. Root causes: zod v4 hoisted from root package.json but workspace packages target v3 APIs; @jam-nodes/core resolved to published npm package instead of local workspace (missing apify, googleSheets, slack credential types); missing @types/node; and several latent code issues masked by cascading type errors.

Changes:

  • Switch to pnpm workspaces — add pnpm-workspace.yaml, use workspace:^ protocol so @jam-nodes/core resolves to local source
  • Zod v3 alignment — root package.json: zod@^4.3.6 → ^3.24.0
  • Core types — widen DefineNodeConfig.inputSchema from z.ZodSchema to z.ZodType<TInput, z.ZodTypeDef, any> to accept schemas with .default() fields; add missing slack credential to NodeCredentials
  • packages/nodes — add @types/node devDep; fix Google Sheets import path; add missing category: 'integration' to 4 Google Sheets node defs; fix index-signature property access in slack-send-message.ts
  • packages/playground-web — pin @hookform/resolvers to 3.9.1 (v3.10+ expects zod v4 types)
  • Lockfile — regenerated via pnpm install

@capy-ai capy-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added 1 comment

category: NodeCategory;
/** Zod schema for validating input */
inputSchema: z.ZodSchema<TInput>;
inputSchema: z.ZodType<TInput, z.ZodTypeDef, any>;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[🟡 Medium] [🟡 Investigate]

The package still declares zod: ^3 || ^4 peer compatibility, but the updated node typing now references z.ZodTypeDef directly in public generic signatures; this type is tied to Zod internals/version surface and may fail for v4 consumers depending on the exact exported type aliases, causing downstream TypeScript errors when defining nodes. Validate by typechecking @jam-nodes/core and a minimal consumer against Zod v4, and if it fails, switch these public signatures to a version-agnostic generic form (e.g., avoid hard-coding ZodTypeDef in exported contracts).

// packages/core/src/utils/define-node.ts
inputSchema: z.ZodType<TInput, z.ZodTypeDef, any>;
/** Zod schema for validating output */
outputSchema: z.ZodType<TOutput, z.ZodTypeDef, any>;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant