Repository navigation
Add start-on-boot setting, default on (#399) - #400
Merged
Merged
Conversation
Re-adds the start_on_boot preference (default true), gated in ReceiverStarter so it only stops background auto-starts (boot broadcast and the periodic network job); opening the app still starts receiving directly. Adds the toggle to Settings > General, strings in EN/ZH/ZH-TW, the setting to anonymous usage stats, and two unit tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #399.
Re-adds the
start_on_bootpreference (defaulttrue): CastBay stays ready to receive after the TV boots without opening the app, while users running a second DLNA receiver (e.g. LeanCast on an unrooted Android 6.0 TV, wherepm disableis rejected) can turn it off in Settings > General.ReceiverSettings.startOnBoot(defaulttrue);ReceiverStarter.start()returns early when it is off, so only background auto-starts (boot broadcast and the periodic network job) are gated — opening the app still starts receiving directly.startOnBootIsOnByDefault; toggling it does not restart the receiver).Testing:
ReceiverSettingsTest, 8/8 pass locally (kotlinc 2.2.10 against android-36 stubs); the full Gradle build, unit tests and lint run on CI here.Note: turning the setting off shows no home-screen hint yet (the old UI had one); a visible "receiving off" hint can follow if wanted.