DB 설정 및 model 정의#1
Open
Jiwon-Yang wants to merge 3 commits into
Open
Conversation
changhoi
requested changes
Feb 17, 2020
changhoi
left a comment
changhoi
left a comment
There was a problem hiding this comment.
@Jiwon-Yang Sequelize 데이터 타입에 익숙하지 않아서. 읽히고 이해한 대로 우선 리뷰를 했습니다. 확인하고 오늘 중으로 꼭 수정 해주세요 ㅠ
Comment on lines
+132
to
+135
| warning: { | ||
| type: DataTypes.STRING(100), | ||
| allowNull: true | ||
| } |
There was a problem hiding this comment.
report과 N:M 관계입니다. 다만 여기가 manTeam과 관계가 걸리는 건지, womanTeam과 관계가 걸리는 건지에 따라 reference가 달라져야 할 텐데 이 부분을 어떻게 해야 할지?..
가장 간단하게는 warningForMan, warningForWoman으로 띡 나눠버리면 될 것 같긴 한데, 다른 방법이 있는지는 잘 모르겠네요
|
아 그리고 여기 레포 말고 앞으로는 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.