Repository navigation
Always use explicit months (no newmoonnumbers) - #110
Merged
Merged
Conversation
These are actually the same tutorial, but updates were only made to one. These should be split once we understand where the one hour mark is, but as a starting point this adds the changes make last year in (1) to (2)
Using newmoonnumbers was (understandably) confusing students.
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
newmoonnumbers are specific to the Portal data and are therefore confusing to students and don't generalize well to broader applications. These changes switch to using explicit months throughout the material, converting to integer indexes as necessary.
Also includes some other minor cleanup in the time-series modeling R tutorials