WIP: Add user-friendly sort order to initial pages in collection replay.json endpoint#3362
Draft
tw4l wants to merge 2 commits into
Draft
WIP: Add user-friendly sort order to initial pages in collection replay.json endpoint#3362tw4l wants to merge 2 commits into
tw4l wants to merge 2 commits into
Conversation
The initial pages loaded for collection replay are not currently sorted except in the order they come out of the database. This commit applies a sort order of isSeed, with secondary and tertiary sorts by url and timestamp. The same sort and sort order are also added to the pagesQueryUrl for the same endpoint, which may require changes in ReplayWeb.page or wabac.js to be able to handle.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3356
This PR applies a new sort order to the
initialPagesreturned by the collection replay.json endpoint, as part of the solution to provide a more sensible order of pages in collection replay.Specifically, this applies
isSeedas the primary sort order, followed byurland thents.Kept in draft for now for two reasons:
pagesQueryUrlto match theinitialPagessort order will break any of the code in RWP/wabac.js that fetches subsequent pages