feat: Show collection slug when shareable#3347
Conversation
98b3d9e to
9b2fabe
Compare
emma-sg
left a comment
There was a problem hiding this comment.
Good first step, but there's a couple issues I encountered:
-
When editing the collection name, the polling on the frontend overwrites the collection url preview whenever it occurs:
Collections.Default.Org.-.Helium.2026-05-27.18-24-01.mp4
-
The layout of the title/collection sharing status/caption feels a little messy - how would you feel about maybe moving the visibility badge above the title?
-
The visibility icon was previously clickable to edit the visibility, the badge no longer is, I feel like it still should be
-
The "Open in New Tab" icon visually appears much larger than the "Copy Shareable Link" icon (even though I know they both occupy the same 14px square): visually, I think it needs to be about
size-2.5to match:
That's fair, I think the layout makes more sense when the thumbnail is present (wip #3350 ) I set up a feature branch so that this change isn't merged into main without the other layout updates https://github.com/webrecorder/browsertrix/tree/frontend-collection-editing-ux-updates
Similarly, I think this could be addressed with the general header layout updates. I'd avoid making badges clickable.
Fixed, good call! |
Co-authored-by: Emma Segal-Grossman <hi@emma.cafe>
3e7bca2 to
2ad391d
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub. |
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
emma-sg
left a comment
There was a problem hiding this comment.
Nice, looking good! Thanks for bearing with me on the details I've been bugging you about 😅
Partially addresses #3312
Changes
Manual testing
Screenshots