Skip to content

feat: Show collection slug when shareable#3347

Open
SuaYoo wants to merge 13 commits into
frontend-collection-editing-ux-updatesfrom
frontend-show-collection-slug
Open

feat: Show collection slug when shareable#3347
SuaYoo wants to merge 13 commits into
frontend-collection-editing-ux-updatesfrom
frontend-show-collection-slug

Conversation

@SuaYoo
Copy link
Copy Markdown
Member

@SuaYoo SuaYoo commented May 27, 2026

Partially addresses #3312

Changes

  • Displays updated collection slug near name
  • Updates collection header layout to match header spacing on other pages
  • Fixes editable text field pencil icon hidden when name is too long
  • Fixes editable text field placeholder width

Manual testing

  1. Log in as crawler
  2. Go to unlisted collection detail page. Verify slug is displayed under name
  3. Edit name. Verify slug updates as name is updated

Screenshots

Page Image/video
Collection (private) Screenshot 2026-05-27 at 1 39 05 PM
Collection (unlisted) Screenshot 2026-05-27 at 1 40 09 PM
Collection (editing name) Screenshot 2026-05-27 at 1 40 25 PM
Collection (small screen) Screenshot 2026-05-27 at 1 40 39 PM

@SuaYoo SuaYoo requested review from emma-sg, ikreymer and tw4l May 27, 2026 20:45
@SuaYoo SuaYoo force-pushed the frontend-show-collection-slug branch from 98b3d9e to 9b2fabe Compare May 27, 2026 21:26
Copy link
Copy Markdown
Member

@emma-sg emma-sg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good first step, but there's a couple issues I encountered:

  • When editing the collection name, the polling on the frontend overwrites the collection url preview whenever it occurs:

    Collections.Default.Org.-.Helium.2026-05-27.18-24-01.mp4
  • The layout of the title/collection sharing status/caption feels a little messy - how would you feel about maybe moving the visibility badge above the title?

  • The visibility icon was previously clickable to edit the visibility, the badge no longer is, I feel like it still should be

  • The "Open in New Tab" icon visually appears much larger than the "Copy Shareable Link" icon (even though I know they both occupy the same 14px square): visually, I think it needs to be about size-2.5 to match:

    Image

Comment thread frontend/src/pages/org/collection-detail/collection-detail.ts
Comment thread frontend/src/components/ui/editable-text-field.ts Outdated
Comment thread frontend/src/components/ui/editable-text-field.ts Outdated
@SuaYoo
Copy link
Copy Markdown
Member Author

SuaYoo commented May 29, 2026

* The layout of the title/collection sharing status/caption feels a little messy - how would you feel about maybe moving the visibility badge above the title?

That's fair, I think the layout makes more sense when the thumbnail is present (wip #3350 ) I set up a feature branch so that this change isn't merged into main without the other layout updates https://github.com/webrecorder/browsertrix/tree/frontend-collection-editing-ux-updates

* The visibility icon was previously clickable to edit the visibility, the badge no longer is, I feel like it still should be

Similarly, I think this could be addressed with the general header layout updates. I'd avoid making badges clickable.

* The "Open in New Tab" icon visually appears much larger than the "Copy Shareable Link" icon

Fixed, good call!

@SuaYoo SuaYoo changed the base branch from main to frontend-collection-editing-ux-updates May 29, 2026 19:22
@SuaYoo SuaYoo requested a review from emma-sg May 29, 2026 22:11
Comment thread frontend/src/components/ui/editable-text-field.ts Outdated
@SuaYoo SuaYoo force-pushed the frontend-show-collection-slug branch from 3e7bca2 to 2ad391d Compare June 4, 2026 03:57
@SuaYoo SuaYoo requested a review from emma-sg June 4, 2026 03:57
@socket-security
Copy link
Copy Markdown

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert  (click "▶" to expand/collapse)
Warn High
Obfuscated code: npm replaywebpage is 91.0% likely obfuscated

Confidence: 0.91

Location: Package overview

From: frontend/package.jsonnpm/replaywebpage@2.4.3

ℹ Read more on: This package | This alert | What is obfuscated code?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/replaywebpage@2.4.3. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

@SuaYoo SuaYoo changed the base branch from frontend-collection-editing-ux-updates to main June 4, 2026 05:13
@SuaYoo SuaYoo changed the base branch from main to frontend-collection-editing-ux-updates June 4, 2026 05:15
Copy link
Copy Markdown
Member

@emma-sg emma-sg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looking good! Thanks for bearing with me on the details I've been bugging you about 😅

Copy link
Copy Markdown
Member

@tw4l tw4l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants