refactor: Webpack 4.x compatibility by joshwiens · Pull Request #75 · webpack-contrib/svg-inline-loader

joshwiens · 2017-12-21T07:19:50Z

Compatibility issues

N/A

Commit message body

 - Updates code style to Prettier
 - Updates engines
 - Updates peerDependencies
 - Enforces commit message formatting
 - Migrates to CircleCI 2.0
 - Removes deprecated React JSX support

BREAKING CHANGE: Drops support for NodeJS 4.x

BREAKING CHANGE: Drops support for Webpack 2.x

BREAKING CHANGE: `loaderUtils.getOptions()` is not backwards compatible

BREAKING CHANGE: JSX Support was deprecated in `v0.4.0` Please use [svg-inline-react](https://www.npmjs.com/package/svg-inline-react) package

- Updates code style to Prettier - Updates engines - Updates loader-utils version - Updates peerDependencies - Enforces commit message formatting - Migrates to CircleCI 2.0 BREAKING CHANGE: Drops support for NodeJS 4.x BREAKING CHANGE: Drops support for Webpack 2.x BREAKING CHANGE: `loaderUtils.getOptions()` is not backwards compatible

michael-ciniawsky · 2017-12-21T11:30:42Z

+function isWarningTag(warningTags, tag) {
+  return warningTags.includes(tag.tagName);
+}
+// FIXME: Due to limtation of parser, we need to implement our


This loader is also a candidate for posthtml and the current logic implemented as posthtml-plugins instead, once I figured out what's going on here in particular :). The current code is just crazy...

randak · 2018-01-02T20:26:51Z

@d3viant0ne Happy New Year! Do you have an estimate on when this might be released?

randak · 2018-01-17T00:34:18Z

@d3viant0ne @michael-ciniawsky Any chance we could see a release for this this month?

mernen · 2018-02-26T03:04:53Z

+
+  validateOptions(schema, options, 'SVGInlineLoader');
+
+  return `module.exports = ${JSON.stringify(


Couldn't this change to ES6 syntax?

randak · 2018-03-28T07:39:22Z

@mernen @d3viant0ne @michael-ciniawsky Could I get a status update on this?

randak · 2018-04-25T17:07:39Z

@bebraw @d3viant0ne @SpaceK33z @TheLarkInn Hi all, I'm not trying to be a pest, but is there anything I can do to help you get this released? Our team would really appreciate it. Thanks!

msphn · 2018-05-03T09:38:48Z

@d3viant0ne did you abandon this change / project?

randak · 2018-05-21T02:19:29Z

😞

msphn · 2018-05-21T11:38:21Z

I migrated to https://www.npmjs.com/package/svg-url-loader and it works fine for me. In case anyone else is interested. I removed all dependency to this lib.

elliottregan · 2018-06-04T20:58:31Z

@msphn Thanks for the tip. Unfortunately, this loader has a lot of useful features that aren't included in that other loader (classPrefix is really important for me).

Fortunately, this still works with Webpack 4 (for me).

dazlious · 2018-06-08T15:58:53Z

Can I help you, to get this PR into production?

ddx32 · 2018-10-23T13:57:52Z

Is there any chance this could get pulled at some point? Is there any issue in the code that prevents that? Update would be very welcome in our team.

SuneRadich · 2019-03-12T08:16:22Z

It is sad that this PR just sits here. Any change it can be integrated in a new release?

elliottregan · 2019-03-14T22:31:50Z

Is there someone over at the core Webpack team that can add someone else as a maintain to this repo? Or maybe transfer ownership if it isn't going to be maintained with the rest of Webpack?

@sokra @jhnns @TheLarkInn @SpaceK33z

elliottregan · 2019-03-14T22:35:34Z

⬆️ @webpack @webpack-contrib

will-russell · 2019-04-04T16:52:36Z

@bebraw, @TheLarkInn, @SpaceK33z - Anyone know what happened to @d3viant0ne ? His last contribution was in February?

bebraw · 2019-04-04T17:01:56Z

@will-russell He (amongst some other developers me included) isn't active in the project anymore.

will-russell · 2019-04-04T17:05:04Z

@will-russell He (amongst some other developers me included) isn't active in the project anymore.

@bebraw - thank you for the reply!

Who was left in charge of the project; do they know this is hanging out there?

RE: @TheLarkInn @SpaceK33z

bebraw · 2019-04-04T17:49:08Z

@will-russell I think it's up to the current contrib team to maintain. Someone show pick up the PR and merge.

CC @evilebottnawi.

alexander-akait · 2019-04-04T17:51:08Z

In todo

aramin · 2019-06-24T11:54:56Z

Are there any news on this issue?

elliottregan · 2019-10-31T01:56:12Z

🦗🦗🦗

liorgreenb · 2020-01-01T16:55:45Z

Also waiting for this

codecov · 2020-04-10T12:08:23Z

Codecov Report

❗ No coverage uploaded for pull request base (master@d2c7218). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #75   +/-   ##
=========================================
  Coverage          ?   45.51%           
=========================================
  Files             ?        5           
  Lines             ?      156           
  Branches          ?       45           
=========================================
  Hits              ?       71           
  Misses            ?       73           
  Partials          ?       12

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2c7218...27f9e37. Read the comment docs.

randak and others added 2 commits December 21, 2017 00:35

refactor: Update to latest loader-utils (#72)

304baef

joshwiens added semver: Major status: Pending type: Refactor labels Dec 21, 2017

michael-ciniawsky approved these changes Dec 21, 2017

View reviewed changes

mernen reviewed Feb 26, 2018

View reviewed changes

randak mentioned this pull request Mar 28, 2018

Fixed issue: #69 with warning message: DeprecationWarning #77

Closed

tech4him1 mentioned this pull request Mar 29, 2018

Upgrade to Webpack 4 decaporg/decap-cms#1214

Merged

10 tasks

anikethsaha approved these changes Feb 8, 2020

View reviewed changes


		validateOptions(schema, options, 'SVGInlineLoader');

		return `module.exports = ${JSON.stringify(

Conversation

joshwiens commented Dec 21, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Compatibility issues

Commit message body

Uh oh!

michael-ciniawsky Dec 21, 2017

Choose a reason for hiding this comment

Uh oh!

randak commented Jan 2, 2018

Uh oh!

randak commented Jan 17, 2018

Uh oh!

mernen Feb 26, 2018

Choose a reason for hiding this comment

Uh oh!

randak commented Mar 28, 2018

Uh oh!

randak commented Apr 25, 2018

Uh oh!

msphn commented May 3, 2018

Uh oh!

randak commented May 21, 2018

Uh oh!

msphn commented May 21, 2018

Uh oh!

elliottregan commented Jun 4, 2018

Uh oh!

dazlious commented Jun 8, 2018

Uh oh!

ddx32 commented Oct 23, 2018

Uh oh!

SuneRadich commented Mar 12, 2019

Uh oh!

elliottregan commented Mar 14, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

elliottregan commented Mar 14, 2019

Uh oh!

will-russell commented Apr 4, 2019

Uh oh!

bebraw commented Apr 4, 2019

Uh oh!

will-russell commented Apr 4, 2019

Uh oh!

bebraw commented Apr 4, 2019

Uh oh!

alexander-akait commented Apr 4, 2019

Uh oh!

aramin commented Jun 24, 2019

Uh oh!

elliottregan commented Oct 31, 2019

Uh oh!

liorgreenb commented Jan 1, 2020

Uh oh!

codecov Bot commented Apr 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

15 participants

joshwiens commented Dec 21, 2017 •

edited

Loading

elliottregan commented Mar 14, 2019 •

edited

Loading

codecov Bot commented Apr 10, 2020 •

edited

Loading