webos: don't fail video init when the webOS ABI fix library is missing - #11
Merged
Merged
Conversation
libwayland-webos-client.so.1 being absent is no longer fatal; the wl_webos_input_manager interface is resolved lazily at its use site instead. 64-bit targets have no such library at all. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JFTrxsLqHkdfDB8hgdT74y
Resolving the interface at the bind site already loads the library, so the eager call only repeated a failed dlopen on targets without it. The static wayland build never reached it at all. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JFTrxsLqHkdfDB8hgdT74y
|
Tested, works great 👍 thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libwayland-webos-client.so.1doesn't exist on 64-bit targets, and its absence was fatal:WaylandWebOS_AbiFixInit()failing setrc = 0inSDL_WAYLAND_LoadSymbols(), soWayland_CreateDevice()returned NULL andSDL_Init(SDL_INIT_VIDEO)failed. Reported in #10.SDL_waylanddyn.c: drop the eagerWaylandWebOS_AbiFixInit()call. It was therc = 0, and it's redundant now that the interface resolves lazily — theSDL_WAYLAND_SHARED=OFFbuild never reached it anyway.SDL_waylandwebos_abifix.c: resolve lazily and NULL-check instead ofSDL_assert, which compiles out underNDEBUGand leavesLoadMapping()dereferencing a null interface. Log at debug level when the library is absent.No build-time switch: the opcodes are read by name from whichever
wl_interfacethe target actually exports, which covers retail firmware, a source-built stack and an absent library alike.SDL_WEBOS_BROKEN_ABIis unrelated — it addsinputSourceto SDL's own event structs to match LG's libSDL2.Builds clean default,
-DSDL_WEBOS_BROKEN_ABI=ON,-DSDL_WAYLAND_SHARED=OFF. Not tested on hardware.🤖 Generated with Claude Code
https://claude.ai/code/session_01JFTrxsLqHkdfDB8hgdT74y