Repository navigation
Avoid mutating shared default metadata objects in load_media - #59
Merged
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_995786918
branch
2 times, most recently
from
October 8, 2026 13:15
4aa78cf to
cae8716
Compare
Using singleton objects (DEFAULT_IMAGE_METADATA / DEFAULT_VIDEO_METADATA) caused container CICP parsing (e.g. for HDR AVIFs) to mutate the shared object in memory, corrupting defaults for subsequent SDR files in tests and in the application. Use factory functions to return fresh metadata objects for each file. PiperOrigin-RevId: 995791573
copybara-service
Bot
force-pushed
the
test_995786918
branch
from
October 8, 2026 13:19
cae8716 to
a62f76a
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid mutating shared default metadata objects in load_media
Using singleton objects (DEFAULT_IMAGE_METADATA / DEFAULT_VIDEO_METADATA)
caused container CICP parsing (e.g. for HDR AVIFs) to mutate the shared
object in memory, corrupting defaults for subsequent SDR files in tests
and in the application.
Use factory functions to return fresh metadata objects for each file.