add support for compile_fail#116
Merged
Merged
Conversation
Contributor
Author
|
The warning fix is a duplicate of #114. |
oconnor663
added a commit
to oconnor663/join_me_maybe
that referenced
this pull request
Dec 22, 2025
The released version is missing `compile_fail` support: webern/cargo-readme#116
Add compile_fail code blocks to the test-project fixtures (lib.rs and multiline.rs) and update all integration test expectations to verify end-to-end behavior through the CLI.
webern
approved these changes
Apr 9, 2026
webern
left a comment
webern
left a comment
Owner
There was a problem hiding this comment.
Looks good. Sorry for the years of delay 😅
Contributor
Author
|
Yay! Thank you! (And I totally get it.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is partly a duplicate of #47 and #83, but I'm hoping that including test updates will make it easier to merge. I've also fixed a warning on
master, which was causing a test failure for me locally. Please let me know if there are any other changes that would make this easier to review.Fixes #46