Skip to content

Commit 40983d1

Browse files
committed
fix: save the webmanifest files in directory defined in faviconOptions.path
1 parent 4e62003 commit 40983d1

62 files changed

Lines changed: 45 additions & 40 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

CHANGELOG.md

Lines changed: 4 additions & 0 deletions

LICENSE

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
ISC License
22

3-
Copyright (c) 2023, webdiscus
3+
Copyright (c) 2024, webdiscus
44

55
Permission to use, copy, modify, and/or distribute this software for any
66
purpose with or without fee is hereby granted, provided that the above

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "html-bundler-webpack-plugin",
3-
"version": "3.4.9",
3+
"version": "3.4.10",
44
"description": "HTML bundler plugin for webpack handles a template as an entry point, extracts CSS and JS from their sources referenced in HTML, supports template engines like Eta, EJS, Handlebars, Nunjucks.",
55
"keywords": [
66
"html",

plugins/favicons-bundler-plugin/index.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,8 @@ class FaviconsBundlerPlugin {
8787

8888
// save favicon manifest files on disk
8989
response.files.forEach(({ name, contents }) => {
90-
compilation.emitAsset(name, new RawSource(contents));
90+
let outputFile = path.posix.join(this.options.faviconsConfig.path, name);
91+
compilation.emitAsset(outputFile, new RawSource(contents));
9192
});
9293
});
9394
}

test/cases/plugin-favicons-minify-true/expected/img/favicons/android-chrome-144x144.png renamed to test/cases/plugin-favicons-minify-true/expected/favicons/android-chrome-144x144.png

File renamed without changes.

test/cases/plugin-favicons-minify-true/expected/img/favicons/android-chrome-192x192.png renamed to test/cases/plugin-favicons-minify-true/expected/favicons/android-chrome-192x192.png

File renamed without changes.

test/cases/plugin-favicons-minify-true/expected/img/favicons/android-chrome-256x256.png renamed to test/cases/plugin-favicons-minify-true/expected/favicons/android-chrome-256x256.png

File renamed without changes.

test/cases/plugin-favicons-minify-true/expected/img/favicons/android-chrome-36x36.png renamed to test/cases/plugin-favicons-minify-true/expected/favicons/android-chrome-36x36.png

File renamed without changes.

test/cases/plugin-favicons-minify-true/expected/img/favicons/android-chrome-384x384.png renamed to test/cases/plugin-favicons-minify-true/expected/favicons/android-chrome-384x384.png

File renamed without changes.

test/cases/plugin-favicons-minify-true/expected/img/favicons/android-chrome-48x48.png renamed to test/cases/plugin-favicons-minify-true/expected/favicons/android-chrome-48x48.png

File renamed without changes.

0 commit comments

Comments
 (0)