Skip to content

Commit 4e62003

Browse files
webdiscuswebdiscus
committed
fix: use the favicons default options for FaviconsBundlerPlugin
1 parent faa2e9e commit 4e62003

82 files changed

Lines changed: 334 additions & 3 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎CHANGELOG.md‎

Lines changed: 4 additions & 0 deletions

‎package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "html-bundler-webpack-plugin",
3-
"version": "3.4.8",
3+
"version": "3.4.9",
44
"description": "HTML bundler plugin for webpack handles a template as an entry point, extracts CSS and JS from their sources referenced in HTML, supports template engines like Eta, EJS, Handlebars, Nunjucks.",
55
"keywords": [
66
"html",

‎plugins/favicons-bundler-plugin/index.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ class FaviconsBundlerPlugin {
2929
constructor(options = {}) {
3030
this.options = options;
3131
// favicons configuration options, see https://github.com/itgalaxy/favicons#usage
32-
this.options.faviconsConfig = { ...config, ...(options.faviconOptions || {}) };
32+
this.options.faviconsConfig = { ...config.defaults, ...(options.faviconOptions || {}) };
3333
}
3434

3535
apply(compiler) {

‎test/cases/option-beforeEmit-modify-urls-in-html-css/expected/html/home.html‎

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
<!DOCTYPE html>
2+
<html>
3+
<head>
4+
<title>Home</title>
5+
<link href="/main-e2ac2b4a.css" rel="stylesheet" />
6+
<script src="/main-5317c1f6.js" defer="defer"></script>
7+
</head>
8+
<body>
9+
<h1>Home</h1>
10+
<p>Remove the `/static/` prefix in generated HTML.</p>
11+
<img src="/image.d4711676.webp" />
12+
<div class="img"></div>
13+
</body>
14+
</html>

‎test/cases/option-beforeEmit-modify-urls-in-html-css/expected/static/image.d4711676.webp‎

398 Bytes

‎test/cases/option-beforeEmit-modify-urls-in-html-css/expected/static/main-5317c1f6.js‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
console.log(">> main");

‎test/cases/option-beforeEmit-modify-urls-in-html-css/expected/static/main-e2ac2b4a.css‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
h1 {
2+
color: green;
3+
}
4+
.img {
5+
width: 160px;
6+
height: 130px;
7+
background-image: url(/image.d4711676.webp);
8+
border: 2px solid darkred;
9+
}

‎test/cases/option-beforeEmit-modify-urls-in-html-css/src/images/image.webp‎

398 Bytes

‎test/cases/option-beforeEmit-modify-urls-in-html-css/src/scripts/main.js‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
console.log('>> main');

‎test/cases/option-beforeEmit-modify-urls-in-html-css/src/styles/main.css‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
h1 {
2+
color: green;
3+
}
4+
.img {
5+
width: 160px;
6+
height: 130px;
7+
background-image: url(../images/image.webp);
8+
border: 2px solid darkred;
9+
}

0 commit comments

Comments
 (0)