fix(firefox): block rapid duplicate submits - #515
Merged
esokullu merged 15 commits intoJul 26, 2026
Merged
Conversation
|
@alectimison-maker is attempting to deploy a commit to the esokullu's projects Team on Vercel. A member of the Team first needs to authorize it. |
…trace-converter feat(traces): add offline OTLP converter
…trace-export feat: add ATIF trace converter
…a-response-token-state fix(captcha): report response token state
…xtract-tool-call-parser refactor(agent): extract text tool-call parser
Object.freeze the module-level IMAGE_BUDGET so accidental mutation of the shared default throws (modules are strict mode) instead of silently changing every caller. Per-capture overrides already spread into fresh objects. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
An _allowResubmit click previously bypassed the guard without being recorded, so a third rapid duplicate was only blocked while the original entry remained in-window. Acknowledged retries now refresh the entry's timestamp and URL, so each further rapid duplicate needs its own acknowledgement. Helpers stay byte-identical across both trees. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…xtract-image-budget refactor(agent): extract image budget helpers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
Firefox already allocated and cleared
_recentSubmitClicks, including after validation-rejected submits, but never consulted it before dispatch. Its architecture documentation explicitly listed this as a limitation. A looping model could therefore click the same Create/Save/Submit-style control twice on the same URL and create duplicate records, while Chrome blocked the second click.Design
_allowResubmitescape hatchTesting
node test/run.js: 1330 passed, 1 inherited failure (package.jsonis25.9.7while the newestCHANGELOG.mdentry is25.9.0)Agent.executeToolintegration regression proving zero content-script dispatch for a duplicatenpm run test:security: 60/60npm run test:fixtures: 125/125npm run test:webmcp: passed with Chrome 150npm run test:ci: passedgit diff --checkCompatibility
Chrome behavior is preserved. Firefox gains the documented duplicate-submit safety behavior; ordinary clicks, navigation, expired entries, explicit retries, and corrected validation failures remain allowed.