click action Navigation#1
Open
chenweiLabri wants to merge 1 commit into
Open
Conversation
Contributor
|
Does it fix your problem ?
Regards
X.B.
De : chenweiLabri [mailto:notifications@github.com]
Envoyé : vendredi 18 mai 2018 12:30
À : webautotester/wat <wat@noreply.github.com>
Cc : Subscribed <subscribed@noreply.github.com>
Objet : [webautotester/wat] click action Navigation (#1)
when click each time, it will do page.waitForNavigation(500),
but sometime it does not navigate, it is just in the same page.
So, I change it to page.waitFor(1000)
just waitFor not navigate, and put the wait time a bit more.
…_____
You can view, comment on, or merge this pull request online at:
#1
Commit Summary
* change to waitFor
File Changes
* M scenario/lib/index.js <https://github.com/webautotester/wat/pull/1/files#diff-0> (44)
* M scenario/src/ClickAction.js <https://github.com/webautotester/wat/pull/1/files#diff-1> (5)
Patch Links:
* https://github.com/webautotester/wat/pull/1.patch
* https://github.com/webautotester/wat/pull/1.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub <#1> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AJ2nic-jPO-UOIgLTlfVx6eI7nnB8qgSks5tzqKrgaJpZM4UEgDd> . <https://github.com/notifications/beacon/AJ2niQLhMb7pYEmPBKb1M6LEn4jTpDUQks5tzqKrgaJpZM4UEgDd.gif>
|
Author
|
Yes, it fixes my Navigation problem.
Regards,
Wei
2018-05-18 15:55 GMT+02:00 Xavier Blanc <notifications@github.com>:
… Does it fix your problem ?
Regards
X.B.
De : chenweiLabri ***@***.***
Envoyé : vendredi 18 mai 2018 12:30
À : webautotester/wat ***@***.***>
Cc : Subscribed ***@***.***>
Objet : [webautotester/wat] click action Navigation (#1)
when click each time, it will do page.waitForNavigation(500),
but sometime it does not navigate, it is just in the same page.
So, I change it to page.waitFor(1000)
just waitFor not navigate, and put the wait time a bit more.
_____
You can view, comment on, or merge this pull request online at:
#1
Commit Summary
* change to waitFor
File Changes
* M scenario/lib/index.js <#1/
files#diff-0> (44)
* M scenario/src/ClickAction.js <https://github.com/
webautotester/wat#1/files#diff-1> (5)
Patch Links:
* https://github.com/webautotester/wat/pull/1.patch
* https://github.com/webautotester/wat/pull/1.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub <https://github.com/
webautotester/wat#1> , or mute the thread <https://github.com/
notifications/unsubscribe-auth/AJ2nic-jPO-UOIgLTlfVx6eI7nnB8qgSks5tzqKrg
aJpZM4UEgDd> . <https://github.com/notifications/beacon/
AJ2niQLhMb7pYEmPBKb1M6LEn4jTpDUQks5tzqKrgaJpZM4UEgDd.gif>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AXV6LPSD0bjLcvf5L_nw5apiQw9TiWClks5tztLogaJpZM4UEgDd>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when click each time, it will do page.waitForNavigation(500),
but sometime it does not navigate, it is just in the same page.
So, I change it to page.waitFor(1000)
just waitFor not navigate, and put the wait time a bit more.