[SyntheticModules] Implements CSS Modules - #20012
Merged
Merged
Conversation
wpt-pr-bot
approved these changes
Oct 31, 2019
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
Collaborator
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1799923
branch
5 times, most recently
from
November 6, 2019 19:02
b1ea461 to
2c34130
Compare
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1799923
branch
from
November 9, 2019 02:26
2c34130 to
c9c68d4
Compare
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1799923
branch
from
November 11, 2019 18:45
c9c68d4 to
8a05d58
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1799923
branch
4 times, most recently
from
November 21, 2019 23:40
2ce9067 to
115a9a2
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1799923
branch
3 times, most recently
from
November 26, 2019 06:03
9955e88 to
c193418
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1799923
branch
2 times, most recently
from
December 10, 2019 05:37
b8ca5e7 to
3236b59
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1799923
branch
5 times, most recently
from
December 14, 2019 00:55
8694fc6 to
408d102
Compare
This is the final change required for CSS Modules to be utilized by developers.
Following the acceptance of this change, if you run chromium with the CSSModules runtime flag, the following is now valid syntax:
<script type="module">
import sheet from "./example.css";
</script>
CSS Modules Explainer:
https://github.com/w3c/webcomponents/blob/gh-pages/proposals/css-modules-v1-explainer.md
CSS Modules Spec PR:
whatwg/html#4898
Bug: 967018
Change-Id: Ifdee5b92259fb7e4e9c8f9aa88e69a98eb55c551
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799923
Commit-Queue: Sam Sebree <sasebree@microsoft.com>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724896}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1799923
branch
from
December 14, 2019 03:27
408d102 to
4c31ae9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the final change required for CSS Modules to be utilized by developers.
Following the acceptance of this change, if you run chromium with the CSSModules runtime flag, the following is now valid syntax:
<script type="module">
import sheet from "./example.css";
</script>
CSS Modules Explainer:
https://github.com/w3c/webcomponents/blob/gh-pages/proposals/css-modules-v1-explainer.md
CSS Modules Spec PR:
whatwg/html#4898
Bug: 967018
Change-Id: Ifdee5b92259fb7e4e9c8f9aa88e69a98eb55c551
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799923
Commit-Queue: Sam Sebree <sasebree@microsoft.com>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724896}