Skip to content

Reject bool where a plain int is expected in _is_valid #2088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NishchayMahor wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −0
Open

Reject bool where a plain int is expected in _is_valid #2088

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions test/collection/test_validator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
[
(1, [int], False),
(1.0, [int], True),
(True, [int], True),
([1, 1], [List], False),
(np.array([1, 2, 3]), [_ExtraTypes.NUMPY], False),
(np.array([1, 2, 3]), [_ExtraTypes.NUMPY, List], False),
Expand Down
4 changes: 4 additions & 0 deletions weaviate/validator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,4 +59,8 @@ def _is_valid(expected: Any, value: Any) -> bool:
return any(isinstance(val, union_arg) for val in value for union_arg in union_args)
else:
return all(isinstance(val, args[0]) for val in value)
# bool is a subclass of int, so isinstance(True, int) is True. Reject a
# bool where a plain int is expected so it is not silently coerced to 0/1.
if expected is int and isinstance(value, bool):
return False
return isinstance(value, expected)