Skip to content

fix: add stability check to wait_for_vector_indexing (Fixes #1412) #2086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rtmalikian wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: add stability check to wait_for_vector_indexing (Fixes #1412) #2086

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions weaviate/collections/batch/batch_wrapper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,13 @@ def wait_for_vector_indexing(
logger.debug("Waiting for async indexing to finish...")
time.sleep(0.25)
waiting_count += 1
# Stability check: wait briefly and re-verify to prevent race condition
# where shards report READY + vectorQueueSize=0 while objectCount
# has not yet caught up to the inserted objects.
# See: https://github.com/weaviate/weaviate-python-client/issues/1412
time.sleep(0.5)
if not self.__is_ready(how_many_failures, shards):
return self.wait_for_vector_indexing(shards, how_many_failures)
logger.debug("Async indexing finished!")

def __get_shards_readiness(self, shard: Shard) -> List[bool]:
Expand Down Expand Up @@ -186,6 +193,13 @@ async def wait_for_vector_indexing(
logger.debug("Waiting for async indexing to finish...")
await asyncio.sleep(0.25)
waiting_count += 1
# Stability check: wait briefly and re-verify to prevent race condition
# where shards report READY + vectorQueueSize=0 while objectCount
# has not yet caught up to the inserted objects.
# See: https://github.com/weaviate/weaviate-python-client/issues/1412
await asyncio.sleep(0.5)
if not await self.__is_ready(how_many_failures, shards):
return await self.wait_for_vector_indexing(shards, how_many_failures)
logger.debug("Async indexing finished!")

async def __get_shards_readiness(self, shard: Shard) -> List[bool]:
Expand Down
Loading